fix(napi): TypedArray is not ArrayBuffer in Deno #2314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: f8c0c7a | Previous: 383b5d0 | Ratio |
|---|---|---|---|
noop#napi-rs |
85608429 ops/sec (±1.17%) |
84470448 ops/sec (±1.4%) |
0.99 |
noop#JavaScript |
823212049 ops/sec (±0.07%) |
814852642 ops/sec (±0.07%) |
0.99 |
Plus number#napi-rs |
23107417 ops/sec (±1.37%) |
22794959 ops/sec (±0.31%) |
0.99 |
Plus number#JavaScript |
821348199 ops/sec (±0.2%) |
810164242 ops/sec (±0.67%) |
0.99 |
Create buffer#napi-rs |
672408 ops/sec (±12.61%) |
618444 ops/sec (±14.37%) |
0.92 |
Create buffer#JavaScript |
3831411 ops/sec (±2.46%) |
3339501 ops/sec (±2.32%) |
0.87 |
createArray#createArrayJson |
54685 ops/sec (±0.38%) |
52441 ops/sec (±0.38%) |
0.96 |
createArray#create array for loop |
9864 ops/sec (±0.52%) |
9692 ops/sec (±0.12%) |
0.98 |
createArray#create array with serde trait |
9917 ops/sec (±0.45%) |
9606 ops/sec (±0.5%) |
0.97 |
getArrayFromJs#get array from json string |
24764 ops/sec (±0.35%) |
24608 ops/sec (±0.13%) |
0.99 |
getArrayFromJs#get array from serde |
13918 ops/sec (±0.1%) |
13810 ops/sec (±0.5%) |
0.99 |
getArrayFromJs#get array with for loop |
16740 ops/sec (±0.31%) |
16619 ops/sec (±0.24%) |
0.99 |
Get Set property#Get Set from native#u32 |
572267 ops/sec (±12.42%) |
562038 ops/sec (±12.56%) |
0.98 |
Get Set property#Get Set from JavaScript#u32 |
536524 ops/sec (±2.51%) |
535728 ops/sec (±2.37%) |
1.00 |
Get Set property#Get Set from native#string |
574045 ops/sec (±11.73%) |
558586 ops/sec (±11.61%) |
0.97 |
Get Set property#Get Set from JavaScript#string |
524804 ops/sec (±2.06%) |
509481 ops/sec (±1.96%) |
0.97 |
Async task#spawn task |
26865 ops/sec (±0.44%) |
25859 ops/sec (±0.29%) |
0.96 |
Async task#ThreadSafeFunction |
9697 ops/sec (±0.47%) |
9250 ops/sec (±1.06%) |
0.95 |
Async task#Tokio future to Promise |
32605 ops/sec (±0.8%) |
31673 ops/sec (±0.95%) |
0.97 |
Query#query * 100 |
3623 ops/sec (±0.62%) |
3594 ops/sec (±0.55%) |
0.99 |
Query#query * 1 |
26808 ops/sec (±0.76%) |
26953 ops/sec (±1.37%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
deleted the
10-17-fix_napi_typedarray_is_not_arraybuffer_in_deno
branch
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.