fix(napi): needless cast to CString before call napi_create_string_utf8#2321
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 21, 2024
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 601a8ec | Previous: de3a60d | Ratio |
|---|---|---|---|
noop#napi-rs |
86722079 ops/sec (±0.09%) |
86712023 ops/sec (±0.36%) |
1.00 |
noop#JavaScript |
819603610 ops/sec (±0.11%) |
819786193 ops/sec (±0.33%) |
1.00 |
Plus number#napi-rs |
23179807 ops/sec (±0.41%) |
23281277 ops/sec (±0.25%) |
1.00 |
Plus number#JavaScript |
818398494 ops/sec (±0.1%) |
816532639 ops/sec (±0.34%) |
1.00 |
Create buffer#napi-rs |
671008 ops/sec (±12.36%) |
663644 ops/sec (±11.92%) |
0.99 |
Create buffer#JavaScript |
3248633 ops/sec (±7.2%) |
3183583 ops/sec (±6.67%) |
0.98 |
createArray#createArrayJson |
53574 ops/sec (±0.52%) |
54335 ops/sec (±0.42%) |
1.01 |
createArray#create array for loop |
9970 ops/sec (±0.51%) |
9897 ops/sec (±0.36%) |
0.99 |
createArray#create array with serde trait |
9943 ops/sec (±0.46%) |
9907 ops/sec (±0.12%) |
1.00 |
getArrayFromJs#get array from json string |
23554 ops/sec (±0.64%) |
23769 ops/sec (±0.5%) |
1.01 |
getArrayFromJs#get array from serde |
13715 ops/sec (±0.21%) |
13589 ops/sec (±0.92%) |
0.99 |
getArrayFromJs#get array with for loop |
16215 ops/sec (±0.36%) |
15950 ops/sec (±0.62%) |
0.98 |
Get Set property#Get Set from native#u32 |
580262 ops/sec (±12.5%) |
575687 ops/sec (±12.78%) |
0.99 |
Get Set property#Get Set from JavaScript#u32 |
552891 ops/sec (±2.4%) |
536543 ops/sec (±2.49%) |
0.97 |
Get Set property#Get Set from native#string |
568768 ops/sec (±11.33%) |
566114 ops/sec (±10.81%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
521172 ops/sec (±2.02%) |
519561 ops/sec (±2%) |
1.00 |
Async task#spawn task |
26852 ops/sec (±0.51%) |
27095 ops/sec (±0.6%) |
1.01 |
Async task#ThreadSafeFunction |
9581 ops/sec (±0.86%) |
9701 ops/sec (±0.5%) |
1.01 |
Async task#Tokio future to Promise |
32328 ops/sec (±0.93%) |
32819 ops/sec (±0.77%) |
1.02 |
Query#query * 100 |
3510 ops/sec (±1.86%) |
3613 ops/sec (±0.57%) |
1.03 |
Query#query * 1 |
26500 ops/sec (±0.98%) |
26891 ops/sec (±0.74%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
c0a253e to
f195691
Compare
f195691 to
601a8ec
Compare
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.