refactor!(napi): remove &str FromNapiValue#2323
Merged
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 1b359f9 | Previous: 4226a42 | Ratio |
|---|---|---|---|
noop#napi-rs |
86883315 ops/sec (±0.27%) |
84652424 ops/sec (±1.73%) |
0.97 |
noop#JavaScript |
824882651 ops/sec (±0.13%) |
820876410 ops/sec (±0.15%) |
1.00 |
Plus number#napi-rs |
23226106 ops/sec (±0.26%) |
22765382 ops/sec (±0.38%) |
0.98 |
Plus number#JavaScript |
821473457 ops/sec (±0.22%) |
822073282 ops/sec (±0.1%) |
1.00 |
Create buffer#napi-rs |
683730 ops/sec (±12.31%) |
669472 ops/sec (±12.88%) |
0.98 |
Create buffer#JavaScript |
3745350 ops/sec (±2.71%) |
3818164 ops/sec (±2.78%) |
1.02 |
createArray#createArrayJson |
55196 ops/sec (±0.53%) |
54054 ops/sec (±0.71%) |
0.98 |
createArray#create array for loop |
10002 ops/sec (±0.45%) |
9982 ops/sec (±0.36%) |
1.00 |
createArray#create array with serde trait |
9966 ops/sec (±0.45%) |
9951 ops/sec (±0.46%) |
1.00 |
getArrayFromJs#get array from json string |
24210 ops/sec (±0.6%) |
23306 ops/sec (±0.75%) |
0.96 |
getArrayFromJs#get array from serde |
13650 ops/sec (±0.48%) |
13331 ops/sec (±0.56%) |
0.98 |
getArrayFromJs#get array with for loop |
16125 ops/sec (±0.49%) |
15871 ops/sec (±0.63%) |
0.98 |
Get Set property#Get Set from native#u32 |
594460 ops/sec (±11.79%) |
573743 ops/sec (±12.84%) |
0.97 |
Get Set property#Get Set from JavaScript#u32 |
525747 ops/sec (±10.84%) |
554535 ops/sec (±2.55%) |
1.05 |
Get Set property#Get Set from native#string |
603167 ops/sec (±1.66%) |
567904 ops/sec (±11.41%) |
0.94 |
Get Set property#Get Set from JavaScript#string |
507662 ops/sec (±2.09%) |
509589 ops/sec (±2.13%) |
1.00 |
Async task#spawn task |
27018 ops/sec (±0.8%) |
26420 ops/sec (±0.67%) |
0.98 |
Async task#ThreadSafeFunction |
9894 ops/sec (±0.68%) |
9308 ops/sec (±1.52%) |
0.94 |
Async task#Tokio future to Promise |
32819 ops/sec (±0.84%) |
32422 ops/sec (±0.77%) |
0.99 |
Query#query * 100 |
3647 ops/sec (±0.37%) |
3543 ops/sec (±0.66%) |
0.97 |
Query#query * 1 |
27595 ops/sec (±0.82%) |
26747 ops/sec (±0.61%) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
10-21-refactor_napi_remove_str_fromnapivalue
branch
from
7a82704 to
32d64ab
Compare
Brooooooklyn
force-pushed
the
10-21-refactor_napi_remove_str_fromnapivalue
branch
from
32d64ab to
1b359f9
Compare
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
richerfu
pushed a commit
to richerfu/napi-rs
that referenced
this pull request
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.