fix(napi-derive): ra warning on Rust 1.82#2329
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 25, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 03ab645 | Previous: 3013886 | Ratio |
|---|---|---|---|
noop#napi-rs |
86404232 ops/sec (±1.27%) |
85222553 ops/sec (±1.01%) |
0.99 |
noop#JavaScript |
822928035 ops/sec (±0.08%) |
819318395 ops/sec (±0.32%) |
1.00 |
Plus number#napi-rs |
23553774 ops/sec (±0.51%) |
22648945 ops/sec (±0.22%) |
0.96 |
Plus number#JavaScript |
822426588 ops/sec (±0.1%) |
820306389 ops/sec (±0.24%) |
1.00 |
Create buffer#napi-rs |
636704 ops/sec (±13.21%) |
666531 ops/sec (±13.48%) |
1.05 |
Create buffer#JavaScript |
3274755 ops/sec (±1.84%) |
3542277 ops/sec (±2.65%) |
1.08 |
createArray#createArrayJson |
54334 ops/sec (±0.49%) |
53470 ops/sec (±0.58%) |
0.98 |
createArray#create array for loop |
9742 ops/sec (±0.17%) |
9794 ops/sec (±0.41%) |
1.01 |
createArray#create array with serde trait |
9915 ops/sec (±0.62%) |
9741 ops/sec (±0.8%) |
0.98 |
getArrayFromJs#get array from json string |
23858 ops/sec (±0.15%) |
23463 ops/sec (±0.16%) |
0.98 |
getArrayFromJs#get array from serde |
13127 ops/sec (±0.66%) |
13666 ops/sec (±0.15%) |
1.04 |
getArrayFromJs#get array with for loop |
15490 ops/sec (±0.65%) |
16006 ops/sec (±0.21%) |
1.03 |
Get Set property#Get Set from native#u32 |
579380 ops/sec (±12.06%) |
577912 ops/sec (±13.35%) |
1.00 |
Get Set property#Get Set from JavaScript#u32 |
552594 ops/sec (±2.18%) |
548997 ops/sec (±2.42%) |
0.99 |
Get Set property#Get Set from native#string |
575456 ops/sec (±11.24%) |
572966 ops/sec (±11.93%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
525487 ops/sec (±1.96%) |
510463 ops/sec (±2.02%) |
0.97 |
Async task#spawn task |
27405 ops/sec (±0.67%) |
27005 ops/sec (±0.39%) |
0.99 |
Async task#ThreadSafeFunction |
9797 ops/sec (±0.9%) |
9541 ops/sec (±0.79%) |
0.97 |
Async task#Tokio future to Promise |
33192 ops/sec (±0.63%) |
33011 ops/sec (±0.78%) |
0.99 |
Query#query * 100 |
3615 ops/sec (±0.74%) |
3646 ops/sec (±0.4%) |
1.01 |
Query#query * 1 |
27598 ops/sec (±0.66%) |
27463 ops/sec (±0.74%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Member
Author
Brooooooklyn
deleted the
10-25-fix_napi-derive_ra_warning_on_rust_1.82
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.