fix!(sys): Node-API accpet NAPI_AUTO_LENGTH parameter type should be isize rather than usize#2331
Merged
Brooooooklyn merged 1 commit intomainfrom Oct 28, 2024
Merged
Conversation
…isize rather than usize
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 4018d0b | Previous: f707f36 | Ratio |
|---|---|---|---|
noop#napi-rs |
86629879 ops/sec (±0.11%) |
91641004 ops/sec (±1.16%) |
1.06 |
noop#JavaScript |
818034424 ops/sec (±0.3%) |
862244613 ops/sec (±0.54%) |
1.05 |
Plus number#napi-rs |
22332109 ops/sec (±0.48%) |
24782114 ops/sec (±0.78%) |
1.11 |
Plus number#JavaScript |
816484188 ops/sec (±0.24%) |
866889342 ops/sec (±0.45%) |
1.06 |
Create buffer#napi-rs |
639965 ops/sec (±12.88%) |
686518 ops/sec (±11.13%) |
1.07 |
Create buffer#JavaScript |
2961795 ops/sec (±2.73%) |
4341768 ops/sec (±2.86%) |
1.47 |
createArray#createArrayJson |
53994 ops/sec (±0.48%) |
56389 ops/sec (±0.71%) |
1.04 |
createArray#create array for loop |
9765 ops/sec (±0.51%) |
10116 ops/sec (±0.71%) |
1.04 |
createArray#create array with serde trait |
9992 ops/sec (±0.52%) |
10481 ops/sec (±0.6%) |
1.05 |
getArrayFromJs#get array from json string |
23714 ops/sec (±0.47%) |
24808 ops/sec (±0.76%) |
1.05 |
getArrayFromJs#get array from serde |
13528 ops/sec (±0.45%) |
14456 ops/sec (±0.66%) |
1.07 |
getArrayFromJs#get array with for loop |
16127 ops/sec (±0.46%) |
17171 ops/sec (±0.71%) |
1.06 |
Get Set property#Get Set from native#u32 |
573420 ops/sec (±13.36%) |
601112 ops/sec (±11.84%) |
1.05 |
Get Set property#Get Set from JavaScript#u32 |
552743 ops/sec (±2.49%) |
526893 ops/sec (±11.25%) |
0.95 |
Get Set property#Get Set from native#string |
555673 ops/sec (±12.51%) |
654871 ops/sec (±1.57%) |
1.18 |
Get Set property#Get Set from JavaScript#string |
515425 ops/sec (±2.17%) |
514356 ops/sec (±14.67%) |
1.00 |
Async task#spawn task |
26846 ops/sec (±0.41%) |
28063 ops/sec (±0.99%) |
1.05 |
Async task#ThreadSafeFunction |
9263 ops/sec (±0.88%) |
10451 ops/sec (±0.82%) |
1.13 |
Async task#Tokio future to Promise |
31568 ops/sec (±1.09%) |
35536 ops/sec (±0.69%) |
1.13 |
Query#query * 100 |
3576 ops/sec (±0.64%) |
3847 ops/sec (±0.83%) |
1.08 |
Query#query * 1 |
26121 ops/sec (±0.93%) |
29287 ops/sec (±0.77%) |
1.12 |
This comment was automatically generated by workflow using github-action-benchmark.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.