fix(napi-derive): object lifetime compile issue#2351
Merged
Brooooooklyn merged 1 commit intomainfrom Nov 11, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: af7971c | Previous: 75ff88c | Ratio |
|---|---|---|---|
noop#napi-rs |
86197039 ops/sec (±0.74%) |
86335823 ops/sec (±0.32%) |
1.00 |
noop#JavaScript |
820670850 ops/sec (±0.11%) |
822278860 ops/sec (±0.09%) |
1.00 |
Plus number#napi-rs |
23484309 ops/sec (±0.17%) |
23086704 ops/sec (±0.95%) |
0.98 |
Plus number#JavaScript |
820543788 ops/sec (±0.13%) |
821700311 ops/sec (±0.1%) |
1.00 |
Create buffer#napi-rs |
633246 ops/sec (±12.57%) |
652866 ops/sec (±13.09%) |
1.03 |
Create buffer#JavaScript |
3541630 ops/sec (±3.07%) |
3173030 ops/sec (±2.34%) |
0.90 |
createArray#createArrayJson |
53794 ops/sec (±0.55%) |
53882 ops/sec (±1.51%) |
1.00 |
createArray#create array for loop |
9928 ops/sec (±0.32%) |
9601 ops/sec (±0.16%) |
0.97 |
createArray#create array with serde trait |
9867 ops/sec (±0.86%) |
9866 ops/sec (±0.09%) |
1.00 |
getArrayFromJs#get array from json string |
23492 ops/sec (±0.79%) |
23433 ops/sec (±0.35%) |
1.00 |
getArrayFromJs#get array from serde |
13090 ops/sec (±0.51%) |
13711 ops/sec (±0.34%) |
1.05 |
getArrayFromJs#get array with for loop |
16063 ops/sec (±0.4%) |
16335 ops/sec (±0.36%) |
1.02 |
Get Set property#Get Set from native#u32 |
579414 ops/sec (±12.88%) |
559825 ops/sec (±13.44%) |
0.97 |
Get Set property#Get Set from JavaScript#u32 |
546835 ops/sec (±2.61%) |
539056 ops/sec (±2.54%) |
0.99 |
Get Set property#Get Set from native#string |
579865 ops/sec (±11%) |
565745 ops/sec (±11.63%) |
0.98 |
Get Set property#Get Set from JavaScript#string |
517209 ops/sec (±1.96%) |
508793 ops/sec (±2.12%) |
0.98 |
Async task#spawn task |
26833 ops/sec (±0.74%) |
26761 ops/sec (±0.53%) |
1.00 |
Async task#ThreadSafeFunction |
9339 ops/sec (±0.91%) |
9169 ops/sec (±2.82%) |
0.98 |
Async task#Tokio future to Promise |
33054 ops/sec (±0.59%) |
31641 ops/sec (±1.25%) |
0.96 |
Query#query * 100 |
3621 ops/sec (±0.6%) |
3605 ops/sec (±0.47%) |
1.00 |
Query#query * 1 |
27112 ops/sec (±0.66%) |
26250 ops/sec (±0.73%) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
deleted the
11-11-fix_napi-derive_object_lifetime_compile_issue
branch
Contributor
|
Hi! I was wondering if you mind if you can create a new release? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eitherwhich it is actually defined #2349