feat(napi): implement ValidateNapiValue for HashMap with any hasher#2374
Merged
Brooooooklyn merged 1 commit intonapi-rs:mainfrom Nov 29, 2024
Conversation
Contributor
Author
|
The lint errors are not related to this PR. |
sapphi-red
deleted the
feat/implement-validate-napi-value-for-hashmap-with-any-hasher
branch
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Dec 2, 2024
<!-- Thank you for contributing! --> ### Description This PR needs napi-rs/napi-rs#2374. <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
underfin
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Dec 9, 2024
<!-- Thank you for contributing! --> ### Description This PR needs napi-rs/napi-rs#2374. <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example,
FromNapiValueandToNapiValuewas implemented forHashMap<K, V, BuildHasherDefault<FxHasher>>, butValidateNapiValuewas not.