fix(napi): delete error reference with raw Error#2388
Merged
Brooooooklyn merged 6 commits intonapi-rs:mainfrom Dec 9, 2024
Merged
fix(napi): delete error reference with raw Error#2388Brooooooklyn merged 6 commits intonapi-rs:mainfrom
Brooooooklyn merged 6 commits intonapi-rs:mainfrom
Conversation
underfin
changed the title
Contributor
|
Can you link the rolldown PR for full context? We can't determine the root issue with just this PR. |
Contributor
Author
#2388 (comment), You can see it. The |
Brooooooklyn
approved these changes
Dec 9, 2024
Brooooooklyn
changed the title
Contributor
Author
|
@Brooooooklyn Could you publish a new version for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rolldown
buildEndhook argument need toJsErrorand also theBindingOutputsneed it, here usingJsError::Cloneto do it, but it segment fault atnapi_delete_reference. So here only delete reference for rawJsError.