feat(napi-derive): support type on #[napi]#2416
Merged
Brooooooklyn merged 2 commits intonapi-rs:mainfrom Jan 2, 2025
Merged
Conversation
Brooooooklyn
changed the title
Brooooooklyn
force-pushed
the
feat_impl_napi_for_type
branch
from
3c5cb96 to
83d745d
Compare
Brooooooklyn
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now types can be added using dtsHeader and dtsHeaderFile, but I think it is also possible to generate part of the types using macros. This would make it easier to align Rust types with TypeScript types.