Skip to content

fix(napi): add back Buffer/TypedArray custom gc on wasi#2421

Merged
Brooooooklyn merged 1 commit into
mainfrom
01-11-fix_napi_add_back_buffer_typedarray_custom_gc_on_wasi
Jan 12, 2025
Merged

fix(napi): add back Buffer/TypedArray custom gc on wasi#2421
Brooooooklyn merged 1 commit into
mainfrom
01-11-fix_napi_add_back_buffer_typedarray_custom_gc_on_wasi

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 1ffac48 Previous: 8ebc851 Ratio
noop#napi-rs 85902674 ops/sec (±0.81%) 86415977 ops/sec (±0.16%) 1.01
noop#JavaScript 816591242 ops/sec (±0.17%) 816517340 ops/sec (±0.15%) 1.00
Plus number#napi-rs 26271594 ops/sec (±0.43%) 23419167 ops/sec (±0.28%) 0.89
Plus number#JavaScript 813858282 ops/sec (±0.5%) 816753550 ops/sec (±0.1%) 1.00
Create buffer#napi-rs 658816 ops/sec (±12.11%) 642981 ops/sec (±12.43%) 0.98
Create buffer#JavaScript 3759919 ops/sec (±3.64%) 3465040 ops/sec (±1.67%) 0.92
createArray#createArrayJson 53145 ops/sec (±0.71%) 50886 ops/sec (±0.54%) 0.96
createArray#create array for loop 9883 ops/sec (±1.43%) 10064 ops/sec (±0.35%) 1.02
createArray#create array with serde trait 10089 ops/sec (±0.28%) 10130 ops/sec (±0.6%) 1.00
getArrayFromJs#get array from json string 23462 ops/sec (±0.48%) 23743 ops/sec (±0.31%) 1.01
getArrayFromJs#get array from serde 13403 ops/sec (±0.54%) 13146 ops/sec (±0.63%) 0.98
getArrayFromJs#get array with for loop 15532 ops/sec (±0.62%) 15259 ops/sec (±0.53%) 0.98
Get Set property#Get Set from native#u32 564139 ops/sec (±12.02%) 558674 ops/sec (±11.95%) 0.99
Get Set property#Get Set from JavaScript#u32 555364 ops/sec (±2.15%) 550222 ops/sec (±2.36%) 0.99
Get Set property#Get Set from native#string 566370 ops/sec (±11.33%) 578393 ops/sec (±11.08%) 1.02
Get Set property#Get Set from JavaScript#string 522189 ops/sec (±2.06%) 529826 ops/sec (±2.01%) 1.01
Async task#spawn task 26126 ops/sec (±0.6%) 26097 ops/sec (±0.88%) 1.00
Async task#ThreadSafeFunction 9340 ops/sec (±1.15%) 9544 ops/sec (±0.8%) 1.02
Async task#Tokio future to Promise 32042 ops/sec (±0.9%) 32401 ops/sec (±0.66%) 1.01
Query#query * 100 3558 ops/sec (±1.04%) 3522 ops/sec (±0.83%) 0.99
Query#query * 1 27084 ops/sec (±0.85%) 27249 ops/sec (±1.01%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@Brooooooklyn
Brooooooklyn merged commit 73d5c1d into main Jan 12, 2025
@Brooooooklyn
Brooooooklyn deleted the 01-11-fix_napi_add_back_buffer_typedarray_custom_gc_on_wasi branch January 12, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant