feat(napi): allow create ReadableStream from polyfill#2424
Merged
Brooooooklyn merged 1 commit intomainfrom Jan 12, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 6b4f206 | Previous: cf0f03e | Ratio |
|---|---|---|---|
noop#napi-rs |
86324851 ops/sec (±0.29%) |
86320115 ops/sec (±0.24%) |
1.00 |
noop#JavaScript |
817181556 ops/sec (±0.11%) |
817794908 ops/sec (±0.09%) |
1.00 |
Plus number#napi-rs |
23195274 ops/sec (±0.46%) |
27101898 ops/sec (±0.64%) |
1.17 |
Plus number#JavaScript |
817873484 ops/sec (±0.07%) |
811515896 ops/sec (±1%) |
0.99 |
Create buffer#napi-rs |
618661 ops/sec (±13.01%) |
661655 ops/sec (±12.29%) |
1.07 |
Create buffer#JavaScript |
3525878 ops/sec (±2.55%) |
3592867 ops/sec (±2.35%) |
1.02 |
createArray#createArrayJson |
54571 ops/sec (±0.46%) |
54947 ops/sec (±0.44%) |
1.01 |
createArray#create array for loop |
9967 ops/sec (±0.63%) |
9934 ops/sec (±0.35%) |
1.00 |
createArray#create array with serde trait |
10178 ops/sec (±0.36%) |
10126 ops/sec (±0.41%) |
0.99 |
getArrayFromJs#get array from json string |
23583 ops/sec (±0.12%) |
23379 ops/sec (±0.64%) |
0.99 |
getArrayFromJs#get array from serde |
13582 ops/sec (±0.12%) |
13506 ops/sec (±0.45%) |
0.99 |
getArrayFromJs#get array with for loop |
16061 ops/sec (±0.26%) |
15926 ops/sec (±0.43%) |
0.99 |
Get Set property#Get Set from native#u32 |
554250 ops/sec (±12.55%) |
568951 ops/sec (±12.58%) |
1.03 |
Get Set property#Get Set from JavaScript#u32 |
550769 ops/sec (±2.33%) |
550079 ops/sec (±2.23%) |
1.00 |
Get Set property#Get Set from native#string |
578934 ops/sec (±10.88%) |
580203 ops/sec (±11.5%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
527984 ops/sec (±1.93%) |
530031 ops/sec (±2.16%) |
1.00 |
Async task#spawn task |
26129 ops/sec (±0.48%) |
26358 ops/sec (±0.27%) |
1.01 |
Async task#ThreadSafeFunction |
9428 ops/sec (±0.84%) |
9354 ops/sec (±1.24%) |
0.99 |
Async task#Tokio future to Promise |
32214 ops/sec (±1.03%) |
31925 ops/sec (±0.97%) |
0.99 |
Query#query * 100 |
3610 ops/sec (±0.59%) |
3577 ops/sec (±0.71%) |
0.99 |
Query#query * 1 |
27585 ops/sec (±0.86%) |
27118 ops/sec (±0.86%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
deleted the
01-12-feat_napi_allow_create_readablestream_from_polyfill
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.