fix(napi): Update from_raw methods on External<T>#2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit was pushed the other day to copy my changes from #2449 into
napi2branchUnfortunately the copied changes introduce a subtle bug which cause it to segfault on napi major version 2.
In this version of napi, the data pointer passed to
napi_create_external()is theobj: *mut TaggedObject<T>field ofExternal<T>(instead of*mut External<T>onmain), whereas theExternal::from_raw_implcode assumes its not a*mut TaggedObject<T>but a*mut External<T>.Because Rust may re-order the fields of a struct, directly casting
*mut TaggedObject<T> -> *mut External<T>is invalid