refactor!(napi): TypedArray API surfaces#2462
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 06980cf | Previous: 3ce5ef1 | Ratio |
|---|---|---|---|
noop#napi-rs |
86436966 ops/sec (±0.22%) |
85944895 ops/sec (±0.16%) |
0.99 |
noop#JavaScript |
817692746 ops/sec (±0.13%) |
815761731 ops/sec (±0.21%) |
1.00 |
Plus number#napi-rs |
27065919 ops/sec (±0.24%) |
26741752 ops/sec (±0.51%) |
0.99 |
Plus number#JavaScript |
816815841 ops/sec (±0.21%) |
815819672 ops/sec (±0.14%) |
1.00 |
Create buffer#napi-rs |
647453 ops/sec (±12.43%) |
659279 ops/sec (±12.88%) |
1.02 |
Create buffer#JavaScript |
3659313 ops/sec (±2.56%) |
3596336 ops/sec (±2.58%) |
0.98 |
createArray#createArrayJson |
54821 ops/sec (±0.41%) |
55148 ops/sec (±0.93%) |
1.01 |
createArray#create array for loop |
10462 ops/sec (±0.37%) |
9868 ops/sec (±0.43%) |
0.94 |
createArray#create array with serde trait |
10394 ops/sec (±0.53%) |
10090 ops/sec (±0.44%) |
0.97 |
getArrayFromJs#get array from json string |
23519 ops/sec (±0.9%) |
24284 ops/sec (±0.26%) |
1.03 |
getArrayFromJs#get array from serde |
12861 ops/sec (±0.59%) |
13462 ops/sec (±0.17%) |
1.05 |
getArrayFromJs#get array with for loop |
13820 ops/sec (±1.24%) |
16145 ops/sec (±0.66%) |
1.17 |
Get Set property#Get Set from native#u32 |
566597 ops/sec (±12.64%) |
579106 ops/sec (±12.29%) |
1.02 |
Get Set property#Get Set from JavaScript#u32 |
544413 ops/sec (±2.64%) |
547881 ops/sec (±2.52%) |
1.01 |
Get Set property#Get Set from native#string |
568109 ops/sec (±11.73%) |
575309 ops/sec (±11.15%) |
1.01 |
Get Set property#Get Set from JavaScript#string |
525938 ops/sec (±2.4%) |
522079 ops/sec (±2.2%) |
0.99 |
Async task#spawn task |
25810 ops/sec (±0.34%) |
25956 ops/sec (±0.85%) |
1.01 |
Async task#ThreadSafeFunction |
9405 ops/sec (±0.7%) |
9379 ops/sec (±0.65%) |
1.00 |
Async task#Tokio future to Promise |
32189 ops/sec (±0.98%) |
31674 ops/sec (±0.64%) |
0.98 |
Query#query * 100 |
3715 ops/sec (±0.34%) |
3582 ops/sec (±1.34%) |
0.96 |
Query#query * 1 |
27413 ops/sec (±0.85%) |
27496 ops/sec (±0.71%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.