chore(napi): merge thread cleanup#2469
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Brooooooklyn
force-pushed
the
02-16-chore_napi_merge_thread_cleanup
branch
from
fea24dc to
7f31f23
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: a39cba8 | Previous: b1f8966 | Ratio |
|---|---|---|---|
noop#napi-rs |
86481686 ops/sec (±0.16%) |
86186596 ops/sec (±0.13%) |
1.00 |
noop#JavaScript |
818563527 ops/sec (±0.09%) |
815482309 ops/sec (±0.09%) |
1.00 |
Plus number#napi-rs |
26527422 ops/sec (±0.54%) |
26810237 ops/sec (±0.31%) |
1.01 |
Plus number#JavaScript |
817812904 ops/sec (±0.08%) |
813038150 ops/sec (±0.18%) |
0.99 |
Create buffer#napi-rs |
614734 ops/sec (±12.19%) |
575372 ops/sec (±11.94%) |
0.94 |
Create buffer#JavaScript |
4257159 ops/sec (±2.9%) |
3323229 ops/sec (±4.14%) |
0.78 |
createArray#createArrayJson |
56258 ops/sec (±0.47%) |
54929 ops/sec (±0.55%) |
0.98 |
createArray#create array for loop |
10220 ops/sec (±0.31%) |
9870 ops/sec (±0.94%) |
0.97 |
createArray#create array with serde trait |
10262 ops/sec (±0.31%) |
9846 ops/sec (±0.96%) |
0.96 |
getArrayFromJs#get array from json string |
24303 ops/sec (±0.64%) |
23618 ops/sec (±0.52%) |
0.97 |
getArrayFromJs#get array from serde |
12518 ops/sec (±0.36%) |
13386 ops/sec (±0.58%) |
1.07 |
getArrayFromJs#get array with for loop |
15873 ops/sec (±0.35%) |
16300 ops/sec (±0.42%) |
1.03 |
Get Set property#Get Set from native#u32 |
583290 ops/sec (±11.99%) |
562157 ops/sec (±11.43%) |
0.96 |
Get Set property#Get Set from JavaScript#u32 |
545684 ops/sec (±2.16%) |
518194 ops/sec (±2.28%) |
0.95 |
Get Set property#Get Set from native#string |
572163 ops/sec (±11.26%) |
548075 ops/sec (±10.41%) |
0.96 |
Get Set property#Get Set from JavaScript#string |
524239 ops/sec (±1.68%) |
499903 ops/sec (±2.39%) |
0.95 |
Async task#spawn task |
26169 ops/sec (±0.57%) |
26106 ops/sec (±0.28%) |
1.00 |
Async task#ThreadSafeFunction |
9516 ops/sec (±0.37%) |
9174 ops/sec (±0.86%) |
0.96 |
Async task#Tokio future to Promise |
31842 ops/sec (±0.97%) |
31694 ops/sec (±0.84%) |
1.00 |
Query#query * 100 |
3605 ops/sec (±0.92%) |
3638 ops/sec (±0.51%) |
1.01 |
Query#query * 1 |
27613 ops/sec (±0.86%) |
26978 ops/sec (±0.72%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
02-16-chore_napi_merge_thread_cleanup
branch
2 times, most recently
from
1c5e11a to
583f5b8
Compare
Brooooooklyn
force-pushed
the
02-16-chore_napi_merge_thread_cleanup
branch
from
583f5b8 to
a39cba8
Compare
Member
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.