chore(napi): remove thread_local! in REFERENCE_MAP - #2470
Merged
Brooooooklyn merged 1 commit intoFeb 16, 2025
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Brooooooklyn
force-pushed
the
02-16-chore_napi_remove_thread_local_in_reference_map
branch
from
February 16, 2025 07:39
e6934ca to
c446d86
Compare
Brooooooklyn
changed the base branch from
graphite-base/2470
to
02-16-chore_napi_merge_thread_cleanup
February 16, 2025 07:39
Brooooooklyn
changed the base branch from
02-16-chore_napi_merge_thread_cleanup
to
graphite-base/2470
February 16, 2025 07:40
Brooooooklyn
force-pushed
the
graphite-base/2470
branch
from
February 16, 2025 07:41
583f5b8 to
a39cba8
Compare
Brooooooklyn
force-pushed
the
02-16-chore_napi_remove_thread_local_in_reference_map
branch
from
February 16, 2025 07:41
c446d86 to
9a18ce3
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 43acf51 | Previous: 0ce8fab | Ratio |
|---|---|---|---|
noop#napi-rs |
86475801 ops/sec (±0.14%) |
86442797 ops/sec (±0.2%) |
1.00 |
noop#JavaScript |
818440555 ops/sec (±0.08%) |
818660509 ops/sec (±0.06%) |
1.00 |
Plus number#napi-rs |
26507432 ops/sec (±0.71%) |
26581735 ops/sec (±0.33%) |
1.00 |
Plus number#JavaScript |
817706097 ops/sec (±0.08%) |
817376531 ops/sec (±0.11%) |
1.00 |
Create buffer#napi-rs |
657198 ops/sec (±12.55%) |
657570 ops/sec (±12.68%) |
1.00 |
Create buffer#JavaScript |
3689681 ops/sec (±2.86%) |
3586752 ops/sec (±2.57%) |
0.97 |
createArray#createArrayJson |
56525 ops/sec (±0.49%) |
55450 ops/sec (±0.44%) |
0.98 |
createArray#create array for loop |
10450 ops/sec (±0.62%) |
10164 ops/sec (±0.34%) |
0.97 |
createArray#create array with serde trait |
10508 ops/sec (±0.45%) |
10211 ops/sec (±0.59%) |
0.97 |
getArrayFromJs#get array from json string |
24354 ops/sec (±0.57%) |
23982 ops/sec (±0.39%) |
0.98 |
getArrayFromJs#get array from serde |
13365 ops/sec (±0.65%) |
12512 ops/sec (±0.29%) |
0.94 |
getArrayFromJs#get array with for loop |
16207 ops/sec (±0.39%) |
16212 ops/sec (±0.06%) |
1.00 |
Get Set property#Get Set from native#u32 |
579521 ops/sec (±11.78%) |
601102 ops/sec (±7.8%) |
1.04 |
Get Set property#Get Set from JavaScript#u32 |
547587 ops/sec (±2.3%) |
543089 ops/sec (±2.44%) |
0.99 |
Get Set property#Get Set from native#string |
575497 ops/sec (±10.76%) |
577267 ops/sec (±10.93%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
518724 ops/sec (±1.93%) |
515169 ops/sec (±1.87%) |
0.99 |
Async task#spawn task |
26209 ops/sec (±0.7%) |
26082 ops/sec (±0.31%) |
1.00 |
Async task#ThreadSafeFunction |
9387 ops/sec (±0.72%) |
9490 ops/sec (±0.77%) |
1.01 |
Async task#Tokio future to Promise |
32521 ops/sec (±0.78%) |
32799 ops/sec (±1.08%) |
1.01 |
Query#query * 100 |
3646 ops/sec (±0.95%) |
3685 ops/sec (±0.43%) |
1.01 |
Query#query * 1 |
28081 ops/sec (±0.73%) |
27484 ops/sec (±0.84%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Member
Author
Merge activity
|
Brooooooklyn
force-pushed
the
02-16-chore_napi_remove_thread_local_in_reference_map
branch
from
February 16, 2025 08:56
9a18ce3 to
43acf51
Compare
Brooooooklyn
deleted the
02-16-chore_napi_remove_thread_local_in_reference_map
branch
February 16, 2025 10:08
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.