fix(napi): compatible with Rust 1.85#2477
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 6d74799 | Previous: b818da2 | Ratio |
|---|---|---|---|
noop#napi-rs |
86318135 ops/sec (±0.47%) |
85963355 ops/sec (±0.63%) |
1.00 |
noop#JavaScript |
818151053 ops/sec (±0.06%) |
814996615 ops/sec (±0.26%) |
1.00 |
Plus number#napi-rs |
25865177 ops/sec (±0.86%) |
26179967 ops/sec (±0.86%) |
1.01 |
Plus number#JavaScript |
817326167 ops/sec (±0.1%) |
813968013 ops/sec (±0.23%) |
1.00 |
Create buffer#napi-rs |
641754 ops/sec (±13.25%) |
648524 ops/sec (±12.47%) |
1.01 |
Create buffer#JavaScript |
3507839 ops/sec (±2.29%) |
3535744 ops/sec (±2.46%) |
1.01 |
createArray#createArrayJson |
56338 ops/sec (±0.13%) |
53205 ops/sec (±0.88%) |
0.94 |
createArray#create array for loop |
10161 ops/sec (±0.45%) |
10247 ops/sec (±0.38%) |
1.01 |
createArray#create array with serde trait |
10168 ops/sec (±0.39%) |
10428 ops/sec (±0.33%) |
1.03 |
getArrayFromJs#get array from json string |
23736 ops/sec (±0.51%) |
23598 ops/sec (±0.73%) |
0.99 |
getArrayFromJs#get array from serde |
12902 ops/sec (±0.54%) |
13561 ops/sec (±0.61%) |
1.05 |
getArrayFromJs#get array with for loop |
16215 ops/sec (±0.27%) |
16239 ops/sec (±0.34%) |
1.00 |
Get Set property#Get Set from native#u32 |
558741 ops/sec (±12.54%) |
581401 ops/sec (±12.07%) |
1.04 |
Get Set property#Get Set from JavaScript#u32 |
539447 ops/sec (±2.58%) |
540791 ops/sec (±2.39%) |
1.00 |
Get Set property#Get Set from native#string |
572791 ops/sec (±11.82%) |
561055 ops/sec (±10.2%) |
0.98 |
Get Set property#Get Set from JavaScript#string |
530086 ops/sec (±1.89%) |
510397 ops/sec (±2.02%) |
0.96 |
Async task#spawn task |
25995 ops/sec (±0.31%) |
26067 ops/sec (±0.64%) |
1.00 |
Async task#ThreadSafeFunction |
9299 ops/sec (±0.64%) |
9396 ops/sec (±0.72%) |
1.01 |
Async task#Tokio future to Promise |
31408 ops/sec (±1.15%) |
31134 ops/sec (±0.92%) |
0.99 |
Query#query * 100 |
3574 ops/sec (±0.84%) |
3677 ops/sec (±0.33%) |
1.03 |
Query#query * 1 |
27305 ops/sec (±0.85%) |
27182 ops/sec (±0.93%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: rust-lang/rust#137510