refactor!(napi): link crt1-reactor.o as poor man's wasi-exec-model=reactor#2480
Merged
Brooooooklyn merged 1 commit intoFeb 25, 2025
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 0a95046 | Previous: ed6da2b | Ratio |
|---|---|---|---|
noop#napi-rs |
85977242 ops/sec (±0.53%) |
86373830 ops/sec (±0.12%) |
1.00 |
noop#JavaScript |
817828559 ops/sec (±0.09%) |
817384604 ops/sec (±0.06%) |
1.00 |
Plus number#napi-rs |
25626079 ops/sec (±0.98%) |
26495614 ops/sec (±1.16%) |
1.03 |
Plus number#JavaScript |
817319655 ops/sec (±0.1%) |
814726791 ops/sec (±0.19%) |
1.00 |
Create buffer#napi-rs |
655713 ops/sec (±12.34%) |
646402 ops/sec (±11.81%) |
0.99 |
Create buffer#JavaScript |
3581174 ops/sec (±2.24%) |
3675244 ops/sec (±2.63%) |
1.03 |
createArray#createArrayJson |
53972 ops/sec (±0.37%) |
55950 ops/sec (±0.47%) |
1.04 |
createArray#create array for loop |
9347 ops/sec (±0.1%) |
10250 ops/sec (±0.5%) |
1.10 |
createArray#create array with serde trait |
9334 ops/sec (±0.32%) |
10481 ops/sec (±0.26%) |
1.12 |
getArrayFromJs#get array from json string |
23549 ops/sec (±0.45%) |
23714 ops/sec (±0.64%) |
1.01 |
getArrayFromJs#get array from serde |
13382 ops/sec (±0.32%) |
12584 ops/sec (±0.28%) |
0.94 |
getArrayFromJs#get array with for loop |
16142 ops/sec (±0.62%) |
15426 ops/sec (±0.4%) |
0.96 |
Get Set property#Get Set from native#u32 |
594637 ops/sec (±11.12%) |
607304 ops/sec (±10.77%) |
1.02 |
Get Set property#Get Set from JavaScript#u32 |
557652 ops/sec (±2.16%) |
552805 ops/sec (±2.34%) |
0.99 |
Get Set property#Get Set from native#string |
567004 ops/sec (±10.88%) |
582939 ops/sec (±10.86%) |
1.03 |
Get Set property#Get Set from JavaScript#string |
531107 ops/sec (±1.77%) |
529942 ops/sec (±2.24%) |
1.00 |
Async task#spawn task |
26223 ops/sec (±0.66%) |
26349 ops/sec (±0.9%) |
1.00 |
Async task#ThreadSafeFunction |
9246 ops/sec (±0.7%) |
9305 ops/sec (±1.03%) |
1.01 |
Async task#Tokio future to Promise |
32045 ops/sec (±1.1%) |
32649 ops/sec (±1.26%) |
1.02 |
Query#query * 100 |
3621 ops/sec (±0.63%) |
3682 ops/sec (±0.43%) |
1.02 |
Query#query * 1 |
27595 ops/sec (±0.77%) |
27913 ops/sec (±1.2%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
deleted the
02-25-refactor_napi_link_crt1-reactor.o_as_poor_man_s_wasi-exec-model_reactor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.