feat(napi): impl into_unknown for External#2598
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 1d40d02 | Previous: 407a400 | Ratio |
|---|---|---|---|
noop#napi-rs |
83826362 ops/sec (±0.12%) |
82596466 ops/sec (±0.87%) |
0.99 |
noop#JavaScript |
818028562 ops/sec (±0.06%) |
817128270 ops/sec (±0.09%) |
1.00 |
Plus number#napi-rs |
26482033 ops/sec (±1.58%) |
26790479 ops/sec (±0.28%) |
1.01 |
Plus number#JavaScript |
815303590 ops/sec (±0.21%) |
812223964 ops/sec (±0.22%) |
1.00 |
Create buffer#napi-rs |
630739 ops/sec (±12.4%) |
659102 ops/sec (±12.21%) |
1.04 |
Create buffer#JavaScript |
3619856 ops/sec (±2.13%) |
3622632 ops/sec (±2.39%) |
1.00 |
createArray#createArrayJson |
55880 ops/sec (±0.33%) |
54970 ops/sec (±0.31%) |
0.98 |
createArray#create array for loop |
9963 ops/sec (±0.22%) |
9926 ops/sec (±0.52%) |
1.00 |
createArray#create array with serde trait |
9970 ops/sec (±0.16%) |
9946 ops/sec (±0.46%) |
1.00 |
getArrayFromJs#get array from json string |
23165 ops/sec (±0.5%) |
23147 ops/sec (±0.58%) |
1.00 |
getArrayFromJs#get array from serde |
12987 ops/sec (±0.54%) |
13100 ops/sec (±0.34%) |
1.01 |
getArrayFromJs#get array with for loop |
16014 ops/sec (±0.49%) |
16147 ops/sec (±0.34%) |
1.01 |
Get Set property#Get Set from native#u32 |
582194 ops/sec (±11.14%) |
566072 ops/sec (±12.21%) |
0.97 |
Get Set property#Get Set from JavaScript#u32 |
536038 ops/sec (±2.22%) |
527480 ops/sec (±2.32%) |
0.98 |
Get Set property#Get Set from native#string |
557155 ops/sec (±10.4%) |
561878 ops/sec (±11.7%) |
1.01 |
Get Set property#Get Set from JavaScript#string |
516978 ops/sec (±1.77%) |
517117 ops/sec (±2.07%) |
1.00 |
Async task#spawn task |
26370 ops/sec (±0.26%) |
26371 ops/sec (±0.52%) |
1.00 |
Async task#ThreadSafeFunction |
9533 ops/sec (±0.67%) |
9360 ops/sec (±0.83%) |
0.98 |
Async task#Tokio future to Promise |
32010 ops/sec (±1.01%) |
31549 ops/sec (±0.74%) |
0.99 |
Query#query * 100 |
3645 ops/sec (±0.63%) |
3684 ops/sec (±0.35%) |
1.01 |
Query#query * 1 |
27494 ops/sec (±0.53%) |
27760 ops/sec (±0.76%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.