refactor!(napi): add lifetime to Array#2599
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: d8028cd | Previous: 4681ac9 | Ratio |
|---|---|---|---|
noop#napi-rs |
83711181 ops/sec (±0.13%) |
81927242 ops/sec (±4.17%) |
0.98 |
noop#JavaScript |
810474937 ops/sec (±0.78%) |
814379430 ops/sec (±0.08%) |
1.00 |
Plus number#napi-rs |
26476886 ops/sec (±0.6%) |
14330262 ops/sec (±1.67%) |
0.54 |
Plus number#JavaScript |
812416850 ops/sec (±0.1%) |
813201081 ops/sec (±0.16%) |
1.00 |
Create buffer#napi-rs |
622613 ops/sec (±13.25%) |
651883 ops/sec (±12.7%) |
1.05 |
Create buffer#JavaScript |
3254287 ops/sec (±2.91%) |
3323399 ops/sec (±1.85%) |
1.02 |
createArray#createArrayJson |
54446 ops/sec (±0.53%) |
54701 ops/sec (±0.31%) |
1.00 |
createArray#create array for loop |
9909 ops/sec (±0.42%) |
9709 ops/sec (±1.08%) |
0.98 |
createArray#create array with serde trait |
9845 ops/sec (±0.49%) |
9564 ops/sec (±1.54%) |
0.97 |
getArrayFromJs#get array from json string |
23198 ops/sec (±0.7%) |
22961 ops/sec (±0.59%) |
0.99 |
getArrayFromJs#get array from serde |
13064 ops/sec (±0.23%) |
13055 ops/sec (±0.44%) |
1.00 |
getArrayFromJs#get array with for loop |
16102 ops/sec (±0.45%) |
14264 ops/sec (±1.52%) |
0.89 |
Get Set property#Get Set from native#u32 |
556052 ops/sec (±13.35%) |
546759 ops/sec (±8.7%) |
0.98 |
Get Set property#Get Set from JavaScript#u32 |
518173 ops/sec (±2.82%) |
498436 ops/sec (±9.77%) |
0.96 |
Get Set property#Get Set from native#string |
556656 ops/sec (±11.4%) |
533647 ops/sec (±11.95%) |
0.96 |
Get Set property#Get Set from JavaScript#string |
505160 ops/sec (±2.11%) |
510424 ops/sec (±2.22%) |
1.01 |
Async task#spawn task |
26221 ops/sec (±0.94%) |
26416 ops/sec (±1.11%) |
1.01 |
Async task#ThreadSafeFunction |
9273 ops/sec (±0.32%) |
9492 ops/sec (±0.66%) |
1.02 |
Async task#Tokio future to Promise |
30747 ops/sec (±0.68%) |
30939 ops/sec (±0.35%) |
1.01 |
Query#query * 100 |
3580 ops/sec (±1.23%) |
3573 ops/sec (±1.09%) |
1.00 |
Query#query * 1 |
27485 ops/sec (±0.96%) |
27686 ops/sec (±0.57%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Brooooooklyn
force-pushed
the
05-05-refactor_napi_add_lifetime_to_array
branch
from
b78aaf0 to
d8028cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.