test: fix flaky - #2601
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: a9b4ee4 | Previous: 55bed7e | Ratio |
|---|---|---|---|
noop#napi-rs |
84074531 ops/sec (±0.09%) |
81866961 ops/sec (±1%) |
0.97 |
noop#JavaScript |
816163901 ops/sec (±0.07%) |
813806477 ops/sec (±0.09%) |
1.00 |
Plus number#napi-rs |
26792887 ops/sec (±0.19%) |
26628914 ops/sec (±0.66%) |
0.99 |
Plus number#JavaScript |
812517373 ops/sec (±0.24%) |
813063551 ops/sec (±0.21%) |
1.00 |
Create buffer#napi-rs |
644839 ops/sec (±12.73%) |
660602 ops/sec (±12.49%) |
1.02 |
Create buffer#JavaScript |
3844961 ops/sec (±1.62%) |
3630438 ops/sec (±2.39%) |
0.94 |
createArray#createArrayJson |
54879 ops/sec (±0.67%) |
55525 ops/sec (±0.49%) |
1.01 |
createArray#create array for loop |
9917 ops/sec (±0.52%) |
9986 ops/sec (±0.1%) |
1.01 |
createArray#create array with serde trait |
9884 ops/sec (±0.51%) |
9889 ops/sec (±0.79%) |
1.00 |
getArrayFromJs#get array from json string |
22757 ops/sec (±0.63%) |
23223 ops/sec (±0.34%) |
1.02 |
getArrayFromJs#get array from serde |
12825 ops/sec (±0.57%) |
13087 ops/sec (±0.27%) |
1.02 |
getArrayFromJs#get array with for loop |
15869 ops/sec (±0.4%) |
16075 ops/sec (±0.85%) |
1.01 |
Get Set property#Get Set from native#u32 |
565878 ops/sec (±12.59%) |
558204 ops/sec (±12.58%) |
0.99 |
Get Set property#Get Set from JavaScript#u32 |
547611 ops/sec (±2.3%) |
535224 ops/sec (±2.34%) |
0.98 |
Get Set property#Get Set from native#string |
564976 ops/sec (±11.33%) |
563367 ops/sec (±11.36%) |
1.00 |
Get Set property#Get Set from JavaScript#string |
513522 ops/sec (±2.71%) |
512482 ops/sec (±1.92%) |
1.00 |
Async task#spawn task |
26196 ops/sec (±0.54%) |
26157 ops/sec (±0.74%) |
1.00 |
Async task#ThreadSafeFunction |
9482 ops/sec (±1.64%) |
9454 ops/sec (±0.73%) |
1.00 |
Async task#Tokio future to Promise |
31772 ops/sec (±0.56%) |
30761 ops/sec (±0.69%) |
0.97 |
Query#query * 100 |
3669 ops/sec (±0.62%) |
3584 ops/sec (±1.05%) |
0.98 |
Query#query * 1 |
27522 ops/sec (±0.65%) |
27929 ops/sec (±0.92%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.