Repository navigation
fix: Fix path escaping issue in metadata parser - #2605
Merged
Merged
Conversation
Contributor
Author
|
@Brooooooklyn Do you know if these two tests are failing from the changes or if they are flaky? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the
cargo metadatacommand is currently run is prone to failure because the path is not escaped. The best way to handle this is to pass the arguments directly as separate to thecargoprocess throughspawnSyncso there is no need to rely on manual escaping.Please let me know if there is anything else I should edit before this can be merged!
I am currently using NAPI v3 so I can also put in the work to get it merged to that version following your guidance.
Here is an example of what happens when the project is run in a path that has a space in the name of a folder.
