refactor!(napi): add lifetime to Object - #2619
Merged
Merged
Conversation
Brooooooklyn
commented
May 10, 2025
Brooooooklyn
commented
Member
- Deprecated JsArrayBuffer and related types
- Impl JsValue for more types (impl for legacy types for compatibility)
Brooooooklyn
force-pushed
the
05-11-refactor_napi_add_lifetime_to_object
branch
3 times, most recently
from
May 11, 2025 04:56
2ec6d1b to
f1111da
Compare
- Deprecated JsArrayBuffer and related types - Impl JsValue for more types (impl for legacy types for compatibility)
Brooooooklyn
force-pushed
the
05-11-refactor_napi_add_lifetime_to_object
branch
from
May 11, 2025 05:19
f1111da to
a17b334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.