Skip to content

feat!(napi): define propertes support symbol as name - #2673

Merged
Brooooooklyn merged 3 commits into
napi-rs:mainfrom
SyMind:define-propertes-support-symbol
May 30, 2025
Merged

feat!(napi): define propertes support symbol as name#2673
Brooooooklyn merged 3 commits into
napi-rs:mainfrom
SyMind:define-propertes-support-symbol

Conversation

@SyMind

@SyMind SyMind commented May 30, 2025

Copy link
Copy Markdown
Contributor

Refactor the Property struct and can pass symbol as name.

when pass symbol as name

let line_join_symbol = env.create_symbol(Some("lineJoins"))?;
Property::new()
        .with_name(env, line_join_symbol)?;

when pass str as name

Property::new()
        .with_utf8_name("miterNative")?;

@SyMind
SyMind marked this pull request as draft May 30, 2025 10:00
@SyMind
SyMind marked this pull request as ready for review May 30, 2025 10:18
@SyMind
SyMind force-pushed the define-propertes-support-symbol branch from 3abc355 to c9080b3 Compare May 30, 2025 10:21
@SyMind
SyMind force-pushed the define-propertes-support-symbol branch from c9080b3 to f3d8e55 Compare May 30, 2025 10:50
@Brooooooklyn Brooooooklyn changed the title feat: define propertes support symbol as name feat!(napi): define propertes support symbol as name May 30, 2025
@Brooooooklyn
Brooooooklyn merged commit 9173e8e into napi-rs:main May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants