perf(napi): PersistedPerInstanceHashMap can be thread local - #2681
Merged
Brooooooklyn merged 4 commits intoJun 4, 2025
Conversation
SyMind
force-pushed
the
perf-PersistedPerInstanceHashMap
branch
from
June 4, 2025 00:36
b5ba986 to
36d37b7
Compare
SyMind
force-pushed
the
perf-PersistedPerInstanceHashMap
branch
from
June 4, 2025 01:26
10a0aef to
74826e3
Compare
SyMind
marked this pull request as ready for review
June 4, 2025 01:42
SyMind
force-pushed
the
perf-PersistedPerInstanceHashMap
branch
from
June 4, 2025 01:56
42ce520 to
6de0cd5
Compare
Brooooooklyn
approved these changes
Jun 4, 2025
Brooooooklyn
changed the title
Member
|
Notes to look back on: I was trying to avoid We can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance analysis revealed unexpected overhead in
napi::bindgen_runtime::module_register::PersistedPerInstanceHashMap<K,V>::borrow_mut.Optimizations
Lock mechanism refinement for PersistedPerInstanceHashMap
Replaced internal
RwLockwithRefCellsince this struct doesn't require Send + Sync implementation, eliminating thread synchronization overhead.Thread-local initialization
Initialized the following global variables via
thread_local!macro for thread safety:Cross-thread sharing enhancement
Refactored
ModuleClassPropertyinto a struct guarded byRwLockto enable safe sharing between JS main thread and worker threads viaMODULE_CLASS_PROPERTIES.