fix(napi-derive): panic while creating type definition when Rust comment contains escape syntax - #2701
Merged
Conversation
…ent contains escape syntax
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Bug: Unintended Newline Replacement in Documentation
The replace(/\\n/g, '\n') operation unconditionally replaces literal \n sequences with actual newlines in js_doc and def fields. This incorrectly transforms instances where developers intend to display the literal text \n in documentation comments or type definitions, rather than an actual newline.
cli/src/utils/typegen.ts#L145-L154
napi-rs/cli/src/utils/typegen.ts
Lines 145 to 154 in 3d5f00d
BugBot free trial expires on June 14, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
Brooooooklyn
deleted the
06-08-fix_napi-derive_panic_while_creating_type_definition_when_rust_comment_contains_escape_syntax
branch
June 8, 2025 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.