fix(napi): wrong drop impl for TypedArray::with_external_data - #2724
Merged
Brooooooklyn merged 1 commit intoJun 23, 2025
Merged
Brooooooklyn merged 1 commit into
Brooooooklyn merged 1 commit into
Conversation
Brooooooklyn
deleted the
06-23-fix_napi_wrong_drop_impl_for_typedarray_with_external_data
branch
June 23, 2025 09:48
Contributor
|
Amazing! Thank you. When you have time, would it be possible to do a release? |
Member
Author
|
@overlookmotel will be released after I address this issue: #2727 |
Contributor
|
Confirmed this fixed the issue. Thank you for swift fix and for doing a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uint8Array::with_external_dataresults in allocation being freed on wrong side (napi-rs v3) #2719