fix(napi): callback should be Fn rather than FnOnce#2749
Merged
Brooooooklyn merged 1 commit intoJun 28, 2025
Conversation
In ThreadsafeFunction::call_with_return_value
Brooooooklyn
deleted the
06-28-fix_napi_callback_should_be_fn_rather_than_fnonce
branch
June 28, 2025 13:57
Contributor
|
@Brooooooklyn Would you please shed more light on the change? I didn't quite get the root cause. I suppose, for each function call, there should only be one affiliated return value, right? |
Member
Author
|
@h-a-n-a you are right, it was my mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ThreadsafeFunction::call_with_return_value