Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/horizontal scroll #100

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@mabasic
Copy link
Contributor

mabasic commented Aug 27, 2019

  • Fixes Image__Large to not cause horizontal scroll to appear.
  • Fixes design bugs that were causing the horizontal scroll to appear on article show.

Before:

63772649-d21bb380-c8d9-11e9-8b4e-0ca5c9250f78

After:

63772656-d6e06780-c8d9-11e9-9f1e-9af7426e946b

Notice the upper black border missing the radius, that is because it went outside the screen and horizontal scroll appeared.

mabasic added 2 commits Aug 27, 2019
Icons addition and subscription fix
@brotzky brotzky merged commit da06997 into narative:master Aug 27, 2019
5 checks passed
5 checks passed
Header rules - gatsby-theme-novela No header rules processed
Details
Pages changed - gatsby-theme-novela 56 new files uploaded
Details
Mixed content - gatsby-theme-novela No mixed content detected
Details
Redirect rules - gatsby-theme-novela 1 redirect rule processed
Details
netlify/gatsby-theme-novela/deploy-preview Deploy preview ready!
Details
@mabasic

This comment has been minimized.

Copy link
Contributor Author

mabasic commented Aug 27, 2019

Any estimate on the version release for this one?

P.S. Do you know how to use a forked version of this theme? I have managed to reference it in package.json but it keeps complaining because the root of the repository is not the root of the theme, if you know what I mean. Yarn workspaces are making it difficult to use the forked version.

@brotzky

This comment has been minimized.

Copy link
Member

brotzky commented Aug 27, 2019

v0.4.6 should have it

And yes, Yarn workspaces make it annoying. You'll have to publish your fork or hope I can merge and publish fast enough :D

@mabasic

This comment has been minimized.

Copy link
Contributor Author

mabasic commented Aug 27, 2019

Got it. 🎉

I was looking forward to using my forked version with fixed component shadowing so that I can continue modifying my blog, but it seems that it will have to wait...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.