Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adds RSS feed #106

Merged
merged 5 commits into from Sep 2, 2019

Conversation

@mabasic
Copy link
Contributor

mabasic commented Aug 29, 2019

Here are the sources from which I have created this:

https://www.gatsbyjs.org/docs/adding-an-rss-feed
https://www.npmjs.com/package/rss
https://www.gatsbyjs.org/packages/gatsby-plugin-feed
https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-feed

I have accidentally delete my forked repository for the previous PR #94 , so I created a new one.

I've managed to figure out how RSS plugin gets its option values and managed to set the feed_url. You will see bellow. But, because of the current issue in the gatsby-feed-plugin the title can't be changed from code, only by hard coding it.

Update. By pinning the dependency to version before this bug was introduced as @jpvalery suggested I got this feature working.

@mabasic mabasic mentioned this pull request Aug 29, 2019
yarn.lock Outdated Show resolved Hide resolved
…tle being required. Adds image_url to the feed.
@mabasic

This comment has been minimized.

Copy link
Contributor Author

mabasic commented Aug 29, 2019

@jpvalery Take a look now. It works :)

Maybe there is a better way for handling feed image. I have even noticed that feedly does not detect the image..

@mabasic mabasic marked this pull request as ready for review Aug 29, 2019
@mabasic mabasic changed the title [WIP] Adds RSS feed [Feature] Adds RSS feed Sep 2, 2019
@mabasic

This comment has been minimized.

Copy link
Contributor Author

mabasic commented Sep 2, 2019

@jpvalery Ready for merge. Take a look.

@jpvalery

This comment has been minimized.

Copy link
Collaborator

jpvalery commented Sep 2, 2019

That'll be @brotzky for the final look - I was merely just a source of advice :)

@brotzky

This comment has been minimized.

Copy link
Member

brotzky commented Sep 2, 2019

Was following a long a bit as it was being done. Looks great overall. Will merge and we'll see if it needs any tweaks as people use it.

Fantastic feature @mabasic and thanks for reviewing and helping @jpvalery.

@brotzky brotzky merged commit cd320e2 into narative:master Sep 2, 2019
5 checks passed
5 checks passed
Header rules - gatsby-theme-novela No header rules processed
Details
Pages changed - gatsby-theme-novela 1 new file uploaded
Details
Mixed content - gatsby-theme-novela No mixed content detected
Details
Redirect rules - gatsby-theme-novela 1 redirect rule processed
Details
netlify/gatsby-theme-novela/deploy-preview Deploy preview ready!
Details
@mabasic

This comment has been minimized.

Copy link
Contributor Author

mabasic commented Sep 2, 2019

@jpvalery Thank you for the advice. I could not have done it without you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.