Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes article seo structured data #128

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@mabasic
Copy link
Contributor

mabasic commented Sep 7, 2019

Fixes issue #127

Additional fixes:

  • adds publisher field which is required by google
  • modified regex to remove whitespace inside microdata but not within strings enclosed with ". This allows the microdata to be stripped of white spaces while still preserving description, headline and author name white spaces.
  • prepended image with siteUrl
  • location.href is undefined when running yarn build causing:
"mainEntityOfPage":{"@type":"WebPage","@id":"undefined"}

To solve this I have added a static query to fetch the site name (used in publisher) & siteUrl which I applied to appropriate places.

You can view the current state of structured data of Novela here

You can view the state of structured data on my blog with this PR

@brotzky brotzky merged commit 7874ed6 into narative:master Sep 7, 2019
6 checks passed
6 checks passed
Header rules - gatsby-theme-novela No header rules processed
Details
Pages changed - gatsby-theme-novela 58 new files uploaded
Details
Mixed content - gatsby-theme-novela No mixed content detected
Details
Redirect rules - gatsby-theme-novela 1 redirect rule processed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/gatsby-theme-novela/deploy-preview Deploy preview ready!
Details
@brotzky

This comment has been minimized.

Copy link
Member

brotzky commented Sep 7, 2019

Thanks @mabasic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.