Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes article seo structured data #128
Conversation
This comment has been minimized.
This comment has been minimized.
Thanks @mabasic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mabasic commentedSep 7, 2019
Fixes issue #127
Additional fixes:
publisher
field which is required by googlemicrodata
but not within strings enclosed with"
. This allows themicrodata
to be stripped of white spaces while still preserving description, headline and author name white spaces.siteUrl
location.href
isundefined
when runningyarn build
causing:To solve this I have added a static query to fetch the site name (used in
publisher
) & siteUrl which I applied to appropriate places.You can view the current state of structured data of Novela here
You can view the state of structured data on my blog with this PR