Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes subscription panel fade when having only one post. #95

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@mabasic
Copy link
Contributor

mabasic commented Aug 27, 2019

This is a small fix which I would not have noticed if I hadn't had only one post.

Before the fix when you had only one post:

Screenshot_2019-08-27 Getting started with Novela

After the fix with one post:

Screenshot_2019-08-27 Getting started with Novela(1)

@mabasic

This comment has been minimized.

Copy link
Contributor Author

mabasic commented Aug 27, 2019

Maybe this is not the best solution. I don't know the cause of the problem, but this fix works.

Because when you have two posts, it works correctly. I don't know what is different. Maybe you will know.

@jpvalery

This comment has been minimized.

Copy link
Collaborator

jpvalery commented Aug 27, 2019

Implemented the same fix on my end. As I made a shadowed component to edit the copy, it was easy to add it there.
(No idea as well as to the why of this issue 🤷‍♂ )

@brotzky

This comment has been minimized.

Copy link
Member

brotzky commented Aug 27, 2019

This is a solid solution. I always overlook that bottom gradient :(
Maybe there's a better fix for that than fixing each element it could go over.

Will handle that in your other PR. Thanks for opening it!

@mabasic mabasic reopened this Aug 27, 2019
@brotzky brotzky merged commit 3fae0b5 into narative:master Aug 27, 2019
5 checks passed
5 checks passed
Header rules - gatsby-theme-novela No header rules processed
Details
Pages changed - gatsby-theme-novela 56 new files uploaded
Details
Mixed content - gatsby-theme-novela No mixed content detected
Details
Redirect rules - gatsby-theme-novela 1 redirect rule processed
Details
netlify/gatsby-theme-novela/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.