From 77a8a1e5adf01d3653531db924f17833bb45f029 Mon Sep 17 00:00:00 2001
From: Alex Scott <alex@narmi.com>
Date: Thu, 28 Oct 2021 12:14:31 -0400
Subject: [PATCH] fix(RadioButtons): allow for options to be updated via change
 of the options prop

---
 src/RadioButtons/index.js         | 24 +++++-------------
 src/RadioButtons/index.stories.js | 42 +++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 18 deletions(-)
 create mode 100644 src/RadioButtons/index.stories.js

diff --git a/src/RadioButtons/index.js b/src/RadioButtons/index.js
index 3890d4f5c..8456c8400 100644
--- a/src/RadioButtons/index.js
+++ b/src/RadioButtons/index.js
@@ -13,29 +13,18 @@ i.e.
     />
 */
 
-const RadioButtons = (props) => {
-  const [radioOptions, setRadioOptions] = useState([]);
-
-  useEffect(() => {
-    setRadioOptions(props.options);
-  }, []);
-
-  const { initialValue, ...nativeElementProps } = props;
-
+const RadioButtons = ({ options, name, initialValue, ...containerProps }) => {
   return (
-    <div
-      className="nds-radiobutton-group nds-typography"
-      {...nativeElementProps}
-    >
-      {Object.entries(radioOptions).map(([label, value]) => (
+    <div className="nds-radiobutton-group nds-typography" {...containerProps}>
+      {Object.entries(options).map(([label, value]) => (
         <div className="nds-radiobutton-container" key={value}>
-          <label className="nds-label" key={label}>
+          <label className="nds-label">
             {label}
             <input
               type="radio"
               defaultChecked={initialValue === value}
               value={value}
-              name={props.name}
+              name={name}
             />
             <div className="nds-checkmark"></div>
           </label>
@@ -47,12 +36,11 @@ const RadioButtons = (props) => {
 
 RadioButtons.propTypes = {
   options: PropTypes.object,
-  disabled: PropTypes.bool,
   name: PropTypes.string,
+  initialValue: PropTypes.any,
 };
 
 RadioButtons.defaultProps = {
-  disabled: false,
   initialValue: false,
 };
 
diff --git a/src/RadioButtons/index.stories.js b/src/RadioButtons/index.stories.js
new file mode 100644
index 000000000..ff05b8495
--- /dev/null
+++ b/src/RadioButtons/index.stories.js
@@ -0,0 +1,42 @@
+import React, { useState } from "react";
+import RadioButtons from "./";
+
+const Template = (args) => <RadioButtons {...args} />;
+
+export const Overview = Template.bind({});
+Overview.args = {
+  options: {
+    OptionA: "A",
+    OptionB: "B",
+    OptionC: "C",
+  },
+  name: "options",
+};
+
+export const Example = () => {
+  const [value, setValue] = useState();
+  return (
+    <div className="nds-typography">
+      <h3> What is your favourite colour? </h3>
+      <RadioButtons
+        options={{
+          Red: "red",
+          Blue: "blue",
+          Green: "green",
+          Yellow: "yellow",
+        }}
+        name="colours"
+        onChange={(e) => {
+          setValue(e.target.value);
+        }}
+        value={value}
+      />
+      <div>{value && `You have selected ${value}`}</div>
+    </div>
+  );
+};
+
+export default {
+  title: "Components/RadioButtons",
+  component: RadioButtons,
+};