docs: Add Spanish translations to Injector/Intl doc pages #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlmestre
changed the title
rlmestre
force-pushed
the
docs/translate-injector-es
branch
from
28e6181
to
a9b6758
Compare
|
|
||
| ## Cómo funciona | ||
|
|
||
| The helper functions injects the `DestroyRef` class from Angular, and on the `onDestroy` lifecycle hook, it emits from the `Subject` and completes it. |
There was a problem hiding this comment.
Looks like we missed removing the original English line, can we remove it?
|
|
||
| #### `extraProviders` | ||
|
|
||
| We can also pass in other providers, via `extraProviders`, to `createInjectionToken` so when we call `provideFn()`, we provide those providers as well. |
There was a problem hiding this comment.
Looks like this one is translated up until this line, it is also a large one, is this intentional?
| } | ||
| ``` | ||
|
|
||
| ## Testing |
There was a problem hiding this comment.
Looks like we missed removing the English portion of this line, can we remove it?
nelsongutidev
approved these changes
Dec 11, 2023
|
@all-contributors please add @rlmestre for doc |
|
I've put up a pull request to add @rlmestre! 🎉 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d511021. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following targets are in progress
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nelsongutidev @Villanuevand