Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add createEffect fn #27

Closed
e-oz opened this issue Sep 13, 2023 · 2 comments · Fixed by #39
Closed

[feat] add createEffect fn #27

e-oz opened this issue Sep 13, 2023 · 2 comments · Fixed by #39
Assignees
Labels
enhancement New feature or request

Comments

@e-oz
Copy link
Contributor

e-oz commented Sep 13, 2023

Don't you mind if I'll add this function?
https://gist.github.com/e-oz/62fed6d626df5fab5e34402b5f6ec06e
It's a standalone port of ComponentStore.effect() method, with 1 modification: it re-subscribes on errors.
Or you could add it yourself (it would be faster, I think), because the original function is not mine anyway so I'm not looking for any credit for that small modification :)

@nartc
Copy link
Collaborator

nartc commented Sep 13, 2023

Go for it!

@nartc nartc changed the title RFC 1 [feat] add createEffect fn Sep 13, 2023
@nartc nartc added the enhancement New feature or request label Sep 13, 2023
@nartc nartc self-assigned this Sep 13, 2023
@dmorosinotto
Copy link
Contributor

I was suggesting the same function from your article @e-oz 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants