Fix #484, Deprecate shell output command #645
Merged
+41
−303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
enhancement
CCB:Ready
This was referenced Apr 27, 2020
skliper
force-pushed
the
fix484-exec-in-shell
branch
from
b074ba2
to
38ca5e7
Compare
skliper
force-pushed
the
fix484-exec-in-shell
branch
from
38ca5e7
to
a3230cb
Compare
|
Forced push to add "deprecated" where appropriate for doxygen. |
|
CCB 2020-04-29 : APPROVED |
astrogeco
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Deprecates the shell output command
Fix #484
Fix #84
See #643 for approaches to replacing "list" functionality (list apps, list tasks, list resources) that was implemented as "special" shell commands.
Testing performed
Build and ran tests locally with SIMULATION=native, ENABLE_UNIT_TESTS=true with and without OMIT_DEPRECATED, passed
Expected behavior changes
When deprecated attempt to send output to shell command will result in command error counter increment (unrecognized function code).
System(s) tested on
Additional context
#643
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC