Make multi-column view available for components with children #90

Closed
jariba opened this Issue Mar 22, 2013 · 10 comments

Projects

None yet

5 participants

@jariba

For components with children, it would be nice to get the multi-column view for the children in the text view by default.

@DanBerrios

The multi-column view is associated with the platform collection type.

@DanBerrios DanBerrios closed this Mar 26, 2013
@DanBerrios DanBerrios reopened this Mar 26, 2013
@jariba

It's possible that #87 can also address this, if Components with children are given collection type properties.

@jariba jariba closed this May 7, 2013
@jariba

oops, didn't mean to close the issue.

@jariba jariba reopened this May 7, 2013
@harleigh harleigh was assigned Aug 2, 2013
@harleigh

MultiColumnView now is able to display not just children components, but rather entire graphs of components (e.g: given a collection, MultiColumnView displays every component associated with a feedID, regardless of the component's depth in the collection, or whether there exists a cycle within the collection). (Pull request possibly today, but definitely tomorrow)

code altered: MultiColView.java

@VWoeltjen
NASA member

To clarify, I don't think visiting deeper components was the desired behavior here, but rather that the view was only available for Collection objects (and not the more general case of other objects with children, such as My Sandbox, which are not of the Collection component type)

@tdayton

Victor is correct that the original design of this feature was to suit the particular need of replacing an existing type of JPL's non-MCT display. But beyond JPL, and probably even for JPL, there is no need to restrict this feature's availability to "Collection" type objects. "Collection" object type was supposed to be a type for plain old dumb boxes. But darn near any type of object should be able to have children. Sounds like we need to spend some design thinking time....

@VWoeltjen
NASA member

Thanks - that is what I meant to say. (It would have been a much better "clarification" if I didn't switch between talking about desired and undesired behavior mid-sentence.)

To summarize:

  • Current implementation restricts MultiColumn view to objects of specific type "CollectionComponent"
  • Desired implementation (per this issue) is to allow MultiColumn view for any component with children (including, but not limited to, Collection objects)

There is a small design choice about whether to allow this view for non-leaf components with zero children (that is, components which could have children, but don't at the moment.) I'd lean toward "allow it" but have no strong opinion. (Note for harleigh, there is an "isLeaf" method on AbstractComponent which would make writing a policy for that fairly trivial.)

@tdayton

I think this view should be allowed on "non-leaf" components having zero children, because the view should not change based on the maybe-trivial fact that a particular component happens to not have children at this moment.

@VWoeltjen
NASA member

Verified in hackathon 9/25/2013 (Mac OS X & Windows 7)

@VWoeltjen VWoeltjen closed this Sep 25, 2013
@harleigh

Verified in Hackathon 9/25/2013 (Linux on otf2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment