-
Notifications
You must be signed in to change notification settings - Fork 42
MMT-3990: Adding Published and Draft Visualizations #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
- Coverage 97.32% 97.32% -0.01%
==========================================
Files 379 381 +2
Lines 6175 6198 +23
Branches 1296 1303 +7
==========================================
+ Hits 6010 6032 +22
- Misses 157 158 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| const renderSearchBar = () => { | ||
| const { type: searchTypeFromPath } = useParams() | ||
| // Don't render SearchBar for Visualizations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference the ticket here too.
|
I've added some minor comments, lint is also complaining about some lines too long. |
Overview
What is the feature?
Users can navigate to a list of published visualizations
Users can navigate to a list of draft visualizations
What is the Solution?
Created a new navigation header and subheaders for Visualizations
**NOTE that the search bar and the long name sorting have been removed. These are not currently supported and we need to wait on CMR to get those fixed. There is a separate ticket to take care of these.
What areas of the application does this impact?
SearchList and DraftList
Testing
Reproduction steps
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist