Skip to content

Conversation

@mandyparson
Copy link
Contributor

@mandyparson mandyparson commented Apr 28, 2025

Overview

What is the feature?

Users can navigate to a list of published visualizations
Users can navigate to a list of draft visualizations

What is the Solution?

Created a new navigation header and subheaders for Visualizations

**NOTE that the search bar and the long name sorting have been removed. These are not currently supported and we need to wait on CMR to get those fixed. There is a separate ticket to take care of these.

What areas of the application does this impact?

SearchList and DraftList

Testing

Reproduction steps

  • **Environment for testing: SIT
  • **Collection to test with: N/A
  1. Spin up branch and see that the new navigation headers are there and that the page loads as expected. Pagination should work as expected.

Attachments

Screenshot 2025-04-28 at 12 29 11 PM Screenshot 2025-04-28 at 12 29 56 PM

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (842face) to head (12d509c).

Files with missing lines Patch % Lines
static/src/js/pages/SearchPage/SearchPage.jsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   97.32%   97.32%   -0.01%     
==========================================
  Files         379      381       +2     
  Lines        6175     6198      +23     
  Branches     1296     1303       +7     
==========================================
+ Hits         6010     6032      +22     
- Misses        157      158       +1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


const renderSearchBar = () => {
const { type: searchTypeFromPath } = useParams()
// Don't render SearchBar for Visualizations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference the ticket here too.

@cgokey
Copy link
Collaborator

cgokey commented Apr 30, 2025

I've added some minor comments, lint is also complaining about some lines too long.

@mandyparson mandyparson requested review from cgokey and htranho May 1, 2025 15:53
@mandyparson mandyparson merged commit a64399e into main May 2, 2025
11 of 12 checks passed
@mandyparson mandyparson deleted the MMT-3990 branch May 2, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants