Skip to content

Conversation

@mandyparson
Copy link
Contributor

Overview

What is the feature?

As a user, I can click on a published or draft Visualization

What is the Solution?

When a user clicks on a published visualization, the published visualization page is rendered (for now it's just the header). When a user clicks on a draft visualization, the draft visualization page with green bubbles is rendered.

What areas of the application does this impact?

DraftPreview, PublishPreview, DraftPage

Testing

Reproduction steps

  • **Environment for testing: SIT
  1. Go to All Visualizations and click on a visualization. Check to see that it looks the same as other Publish Previews.
  2. Go to Drafts and click a draft visualization. Check to see that it looks the same as other Draft Previews. Please note that at this time we are not building out Maps as they are not ready. QUESTION: Are we satisfied with these headings? Should we combine any?

Attachments

Screenshot 2025-05-06 at 10 11 12 AM Screenshot 2025-05-06 at 10 11 35 AM

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (99e9aa6) to head (ad1d9a2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   97.88%   97.89%           
=======================================
  Files         384      389    +5     
  Lines        6348     6361   +13     
  Branches     1321     1340   +19     
=======================================
+ Hits         6214     6227   +13     
  Misses        133      133           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mandyparson mandyparson merged commit 79bde08 into main May 7, 2025
7 checks passed
@mandyparson mandyparson deleted the MMT-3991 branch May 7, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants