Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS_ModuleLoad() 2nd and 3rd args need to be const #46

Closed
skliper opened this issue Sep 30, 2019 · 4 comments
Closed

OS_ModuleLoad() 2nd and 3rd args need to be const #46

skliper opened this issue Sep 30, 2019 · 4 comments

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

The current integration candidate for CFS_CFE includes code
that passes (char const *) pointers as the 2nd and 3rd
parameters to the OS_ModuleLoad() function. In order for this
to compile without warnings, these parameters of this function
need to carry const qualifiers in the header defining the
function and in the function itself.

The function does not modify data pointed at by these
parameters, so the const qualifier is appropriate.

This change does not require changes to callers (but does
allow them to pass pointers to const data).

This change will need to be included in the 2015-03-10
integration candidate synchronized across all projects.

( I thought I had seen a ticket for this, but was unable
to lay hands on it. )

@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 23. Created by glimes on 2015-03-10T18:18:42, last modified: 2015-07-13T17:51:32

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2015-03-11 09:35:01:

Ticket #36 is supposed to address this but I had rolled it up with some other stuff. We can keep it as a separate effort though - adding "const" is a good thing by itself and it should be done wherever possible.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-03-11 15:32:04:

I was thinking of adding this to the current integration candidate
but managed to tangle myself up in other related changes. For 2015-03-10
integration candidate, I will just ignore the warning ...

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2015-07-13 17:51:32:

Just peeked at the future and #36 fixes this.

@skliper skliper closed this as completed Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant