Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report version when responding to NoOp Comand to match Sample App template #135

Closed
2 tasks done
thnkslprpt opened this issue Oct 22, 2022 · 0 comments · Fixed by #136
Closed
2 tasks done

Report version when responding to NoOp Comand to match Sample App template #135

thnkslprpt opened this issue Oct 22, 2022 · 0 comments · Fixed by #136

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Copy of nasa/ci_lab#52 for to_lab
to_lab does not report version information with NOOP event

Expected behavior
Report version info along with NOOP command as do the other cFS components/apps.

Code snips

to_lab/fsw/src/to_lab_app.c

Lines 354 to 359 in 9e2ad8c

int32 TO_LAB_Noop(const TO_LAB_NoopCmd_t *data)
{
CFE_EVS_SendEvent(TO_LAB_NOOP_INF_EID, CFE_EVS_EventType_INFORMATION, "No-op command");
++TO_LAB_Global.HkTlm.Payload.CommandCounter;
return CFE_SUCCESS;
}

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Oct 22, 2022
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Oct 22, 2022
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Nov 30, 2023
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Nov 30, 2023
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Nov 30, 2023
thnkslprpt added a commit to thnkslprpt/to_lab that referenced this issue Feb 23, 2024
dzbaker added a commit that referenced this issue Feb 23, 2024
…on-to-noop-event

Fix #135, Add version information to NOOP event
dzbaker added a commit that referenced this issue Feb 23, 2024
…on-to-noop-event

Fix #135, Add version information to NOOP event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant