Commits on May 21, 2012
  1. @fabpot

    fixed CS

    fabpot committed May 21, 2012
  2. @fabpot

    merged 2.0

    fabpot committed May 21, 2012
  3. @fabpot

    fixed CS

    fabpot committed May 21, 2012
  4. @fabpot

    merged branch davidwindell/issue_4338 (PR #4357)

    Commits
    -------
    
    0a3dd0f [Console] Check for existence of proc_open to fix #4338
    
    Discussion
    ----------
    
    [Console] Check for existence of proc_open to fix #4338
    
    It is quite common to disable proc_open for security purposes.
    
    This PR checks for the existence of the proc_open function and fixes Issue #4338
    
    Replacement for PR4356
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-21T10:49:59Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1387784) (merged dd991bea into 1407f11).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-21T11:35:21Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1387991) (merged 0a3dd0f into 1407f11).
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-21T12:17:32Z
    
    I forgot to ask you to sent a new PR for the 2.0 branch instead of master. Thanks.
    
    ---------------------------------------------------------------------------
    
    by davidwindell at 2012-05-21T13:03:36Z
    
    proc_open is not used in 2.0?
    fabpot committed May 21, 2012
  5. @davidwindell
  6. @fabpot

    merged branch stof/allow_doctrine_2_3 (PR #4350)

    Commits
    -------
    
    0581c3a Added missing dependency to doctrine common in the global composer.json
    cdfb0b1 Changed composer constraint to allow Doctrine 2.3 too
    
    Discussion
    ----------
    
    Changed composer constraint to allow Doctrine 2.3 too
    
    This allows both the 2.2.x and 2.3.x series for the Doctrine constraints instead of restricting to 2.2.x (thus allowing me to allow Doctrine 2.3 in DoctrineBundle too).
    
    It also fixes some constraint that were missed when bumping the requirement to Doctrine 2.2 and added the missing deps in the global file (FrameworkBundle declares its dependency to ``doctrine/common`` for the ``annotation_reader`` service but it was not declared in the global file)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-20T20:36:06Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1383231) (merged 0581c3a into 1407f11).
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-20T20:56:18Z
    
    The failure is because the doctrine ORM does not allow Doctrine Common 2.2.x but only stable releases (see doctrine/doctrine2#351 fixing it) and Composer seems to resolve dev dependencies by considering all previous resolved deps as fixed whereas downgrading common to 2.2.2 could have worked to satisfy all deps
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-21T05:56:56Z
    
    So, I cannot merge this until the composer bug is fixed (ping @naderman)
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-21T07:00:29Z
    
    you could merge it now. The PR to the ORM has been merged so the composer.json is not triggering the issue anymore
    fabpot committed May 21, 2012
  7. @fabpot

    merged branch kepten/ticket_1813 (PR #3551)

    Commits
    -------
    
    a450d00 [HttpFoundation] HTTP Basic authentication is broken with PHP as cgi/fastCGI under Apache
    
    Discussion
    ----------
    
    [HttpFoundation] HTTP Basic authentication is broken with php-cgi under Apache
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #1813
    Todo: -
    
    In order to work, add this to the .htaccess:
    
    RewriteEngine on
    RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteRule ^(.*)$ app.php [QSA,L]
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-03-10T17:34:26Z
    
    you should also add a unit test for this
    
    ---------------------------------------------------------------------------
    
    by kepten at 2012-03-11T15:34:04Z
    
    Thanks for the feedback, I committed the changes.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-04-04T01:59:53Z
    
    @fabpot could you review it ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-04-04T07:15:34Z
    
    My comments:
    
     * `ServerBag` represents what we have in the `$_SERVER` global variables. As such, the code should be moved to the `getHeaders()` method instead like the other tweaks we do for the HTTP headers.
    
     * A comment must be added explaining why this is needed and the configuration the user must have to make it work (then remove the Github URLs).
    
     * The code should only be executed when `PHP_AUTH_USER` is not available (to not have any overhead when not needed).
    
    ---------------------------------------------------------------------------
    
    by danielholmes at 2012-04-14T13:27:09Z
    
    A quick note on that .htaccess/apache configuration required, if adding to the Symfony SE htaccess file, then it will need to look like this:
    
    ```
    <IfModule mod_rewrite.c>
        RewriteEngine On
    
        RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
    
        RewriteCond %{REQUEST_FILENAME} !-f
        RewriteRule ^(.*)$ app.php [QSA,L]
    </IfModule>
    ```
    
    NOTE: No **,L** in the Authorization Rewrite as in the original example - it prevents the front controller rewrite from happening
    
    ---------------------------------------------------------------------------
    
    by towards at 2012-04-20T16:12:49Z
    
    @kepten you were faster than me applying @fabpot's comments :) nevertheless part of the bug hunt day I also modified the ServerBag class and tested them on a productive LAMP hosting server using Apache and FastCGI
    
    ---------------------------------------------------------------------------
    
    by kepten at 2012-04-20T16:15:57Z
    
    ok, so is my PR is useless or should I still fix problems?
    
    ---------------------------------------------------------------------------
    
    by towards at 2012-04-20T16:20:26Z
    
    your PR is fine for sure and I don't want to interfere, just wanted to mention that part of the bug hunt day of Symfony I had a go at this PR as an "exercise" but just saw later on that you already fixed the problem, so you can ignore my pushes
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-04-20T16:20:36Z
    
    I have been working with @towards: your PR is useful, please implement his comments and squash your PR.
    
    ---------------------------------------------------------------------------
    
    by kepten at 2012-04-20T16:59:07Z
    
    never squashed before, is it okay now? :)
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-04-20T17:21:07Z
    
    it is
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-20T19:57:51Z
    
    @fabpot this should be ready to be merged
    fabpot committed May 21, 2012
Commits on May 20, 2012
  1. @stof

    Added missing dependency to doctrine common in the global composer.json

    Doctrine Common is a dependency of FrameworkBundle for the annotation
    reader.
    stof committed May 20, 2012
  2. @stof
  3. @fabpot

    fixed CS

    fabpot committed May 20, 2012
  4. @fabpot

    merged 2.0

    fabpot committed May 20, 2012
  5. @fabpot

    fixed CS

    fabpot committed May 20, 2012
  6. @fabpot
Commits on May 19, 2012
  1. @fabpot

    merged branch craue/patch-21 (PR #4340)

    Commits
    -------
    
    0f7835d added missing dot in ValidationListener as follow-up to #3922
    
    Discussion
    ----------
    
    added missing dot in ValidationListener as follow-up to #3922
    
    added missing dot in ValidationListener as follow-up to #3922
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T13:35:28Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374601) (merged 0f7835d into ea2dd12).
    fabpot committed May 19, 2012
  2. @craue
  3. @fabpot

    fixed CS

    fabpot committed May 19, 2012
  4. @fabpot

    merged branch clemens-tolboom/pofileloader-better-whitelines (PR #4339)

    Commits
    -------
    
    fb6cf3e Allow for missing whitelines.
    
    Discussion
    ----------
    
    Allow for missing whitelines.
    
    The Gettext specification allows for 'whitespace is optional' between message string.
    
    For this to work PoFileLoader needs to save found messages on more places while processing. Thus a new method is introduced.
    
    For the tests to work PoFileDumper was changed slightly to only emit white-lines when necessary.
    
    I added more documentation from the GNU gettext documentation to make the code more understandable.
    
    When [[BUG] PoFileLoader pluralhandling uses interval instead of index.](symfony#4336) this patch needs some small rework.
    
    (this is part of [[WIP]: Allow Drupal to use Translate component)](symfony#4249)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T12:44:19Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374295) (merged fb6cf3e into 58b9245).
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-19T13:19:29Z
    
    you need to rebase your branch. github tells us it cannot be merged automatically
    fabpot committed May 19, 2012
  5. @fabpot

    merged branch clemens-tolboom/pofileloader-emptytranslations (PR #4337)

    Commits
    -------
    
    dd60166 Fixed for allowing empty translation.
    
    Discussion
    ----------
    
    Fixed for allowing empty translation.
    
    PoFileLoader should accept empty translations.
    
    PoFileLoader calls array_filter just before returning the $messages thus filtering empty translations.
    
    For Drupal we need to be able to load and then translate incomplete PO and POT files.
    
    (this is part of [[WIP]: Allow Drupal to use Translate component](symfony#4249))
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T11:14:39Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373933) (merged 5ee0b1e6 into 58b9245).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T12:09:48Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374129) (merged dd60166 into 58b9245).
    fabpot committed May 19, 2012
  6. @fabpot

    merged branch clemens-tolboom/pofileloader-pluralhandling (PR #4336)

    Commits
    -------
    
    4c4d889 Fixed PoFileLoader pluralhandling from interval to index.
    
    Discussion
    ----------
    
    [BUG] PoFileLoader pluralhandling uses interval instead of index.
    
    PoFileLoaders parsed Gettext messages as interval but should have used indexed.
    
    I added index only message strings to MessageSelectorTest to reflect this.
    
    (this is part of symfony#4249)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T10:11:09Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373653) (merged 4c4d889 into 58b9245).
    fabpot committed May 19, 2012
  7. @clemens-tolboom
  8. @clemens-tolboom
  9. @clemens-tolboom
  10. @fabpot

    removed unused use statements

    fabpot committed May 19, 2012
  11. @fabpot

    merged 2.0

    fabpot committed May 19, 2012
  12. @fabpot

    removed unused use statements

    fabpot committed May 19, 2012
  13. @fabpot

    merged branch stof/profiler_fix (PR #4332)

    Commits
    -------
    
    beb8d18 [WebProfilerBundle] Fixed the displaying of the toolbar in the profiler
    
    Discussion
    ----------
    
    [WebProfilerBundle] Fixed the displaying of the toolbar in the profiler
    
    When re-adding the clearing div a few days ago, you forgot to put it in the ``if``, thus breaking the design of the profiler (adding 50px above the toolbar)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-18T22:37:12Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1371378) (merged beb8d18 into 18132c1).
    fabpot committed May 19, 2012
Commits on May 18, 2012
  1. @stof
  2. @fabpot

    removed empty files

    fabpot committed May 18, 2012
  3. @fabpot

    removed empty files

    fabpot committed May 18, 2012
  4. @fabpot

    fixed CS

    fabpot committed May 18, 2012
  5. @fabpot

    Merge branch '2.0'

    * 2.0:
      fixed CS
      fixed CS
    fabpot committed May 18, 2012
  6. @fabpot

    fixed CS

    fabpot committed May 18, 2012
  7. @fabpot

    fixed CS

    fabpot committed May 18, 2012
  8. @fabpot

    merged 2.0

    fabpot committed May 18, 2012
  9. @fabpot

    added missing LICENSE files

    fabpot committed May 18, 2012