New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename shared library to match package name #63

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tarsius
Copy link
Contributor

tarsius commented Oct 28, 2016

A package should come with a library that matches its name.
The commentary of that library will then be used on Melpa as
the package description.

Rename shared library to match package name
A package should come with a library that matches its name.
The commentary of that library will then be used on Melpa as
the package description.

@tarsius tarsius closed this Nov 30, 2016

@tarsius tarsius reopened this Nov 30, 2016

@nashamri

This comment has been minimized.

Copy link
Owner

nashamri commented Nov 30, 2016

@tarsius thanks for this, I've been really busy lately. So, sorry for talking so long for me to reply.
I'm just wondering if this change will cause any issues with either MELPA or spacemacs.

I haven't looked into it yet, but if you have any thoughts on whether this change will cause any issues, I'm all ears 😄

@tarsius

This comment has been minimized.

Copy link
Contributor

tarsius commented Nov 30, 2016

Actually I have learned that this change can be problematic after I have proposed it, see melpa/melpa#3668 (comment). I intend to work with Steve to come up with a suitable convention for such two-variant-themes, but haven't gotten around to that yet.

I recommend you don't merge this just yet, or even close it. Once I have figured things out I will update this pull request or open a new one.

@nashamri

This comment has been minimized.

Copy link
Owner

nashamri commented Nov 30, 2016

@tarsius oh brilliant, thanks. I guess being lazy can be beneficial sometimes 😄

@nashamri

This comment has been minimized.

Copy link
Owner

nashamri commented Nov 30, 2016

Actually we did discuss that issue a bit, me and Steve, in my original PR for spacemacs-theme to be added to MELPA:
melpa/melpa#2896

I do hate that the commentary section is not showing up in the theme MELPA page https://melpa.org/#/spacemacs-theme

@tarsius

This comment has been minimized.

Copy link
Contributor

tarsius commented Nov 30, 2016

Ah, thanks for that pointer! Well, I can't really think of a satisfactory solution, which is part of the reason I haven't started a conversation about this yet. (But if you have any ideas...)

@nashamri nashamri referenced this pull request Oct 20, 2017

Closed

Create spacemacs-theme-use #89

@tarsius tarsius closed this Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment