Modification to allow site to be injected via a GET parameter #2

Merged
merged 1 commit into from Jul 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

ginnyd commented Jul 16, 2012

As we discussed the other day, here is a change that will allow the site to be injected via a GET parameter, thus allowing multiple sites to be supported by the GEM concurrently

nashby merged commit 8b9c7e3 into nashby:master Jul 16, 2012

Owner

nashby commented Jul 16, 2012

@ginnyd Thank you!

Contributor

ginnyd commented Jul 16, 2012

No problem, sorry it took so long, I spent way too long trying to figure
out whether I should create a new fork and make the changes and then a pull
request or if I could somehow reuse the existing fork I had and then do a
new PR. Still not sure what the "correct" way is, but I ended up just
killing the last fork I had and then doing a new fork.

On Mon, Jul 16, 2012 at 2:13 PM, Vasiliy Ermolovich <
reply@reply.github.com

wrote:

@ginnyd Thank you!


Reply to this email directly or view it on GitHub:

#2 (comment)

Owner

nashby commented Jul 16, 2012

No worries! Yeah the right way was to make a new branch and a new PR. You can find a lot of information about pull requests here https://help.github.com/
Thanks again!

Contributor

ginnyd commented Jul 16, 2012

Cool! I guessed right. Is destroying the old repo (the one created by the
original fork) the right thing to do as well? All the docs I could find on
the site talked about setting a new fork up and creating a PR but nothing
about the second one on the same master project.

On Mon, Jul 16, 2012 at 2:52 PM, Vasiliy Ermolovich <
reply@reply.github.com

wrote:

No worries! Yeah the right way was to make a new branch and a new PR. You
can find a lot of information about pull requests here
https://help.github.com/
Thanks again!


Reply to this email directly or view it on GitHub:

#2 (comment)

Owner

nashby commented Jul 16, 2012

Common workflow is the next:

  1. Fork the repo.
  2. Create a new branch with git checkout -b branch_name
  3. Make PR with your changes from that branch.

and if you have to do another PR you just repeat steps 2-3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment