New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to pages are not rendered in the menu even with DISPLAY_PAGES_ON_MENU=True #5

Closed
jarobase opened this Issue Feb 8, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@jarobase

jarobase commented Feb 8, 2017

It seems that the pages are not visible on the menu. DISPLAY_PAGES_ON_MENU is set to true in pelicanconf.py. The pages are generated with THEME = 'notmyidea' but not with THEME = 'pelican-blueidea'.

Am I the only ne to encounter this bug?
Otherwise, the theme is working as expected.

@jarobase

This comment has been minimized.

jarobase commented Feb 21, 2017

After some tests I finally managed to get rid of the bug. I simply copied the content of the templates folder of the default theme (notmyidea) in the the templates folder of pelican-blueidea. It works. It seems that pelican updated the file base.html. Thanks again for this nice theme.

@maneesha

This comment has been minimized.

maneesha commented May 29, 2017

I spent a long time troubleshooting this today using the same theme. In case anyone else ever comes across this, here's my fix. I'm not sure the entire templates folder needs to be replaced. The template had an all uppercase variable name when it should have been lowercase. In the file templates/base.html :

The line {% for pg in PAGES | sort(attribute=PAGES_SORT_ATTRIBUTE) %} should be
{% for pg in pages | sort(attribute=PAGES_SORT_ATTRIBUTE) %}

@andreagrandi

This comment has been minimized.

andreagrandi commented Jun 28, 2017

Thanks @maneesha I think it's the case. Pelican author mentions it in the documentation http://docs.getpelican.com/en/stable/faq.html#since-i-upgraded-pelican-my-pages-are-no-longer-rendered the problem is that many of these themes are completely out of date / abandoned

@blueicefield

This comment has been minimized.

Collaborator

blueicefield commented Jul 27, 2017

I'm not using Pelican anymore but I will try time to fix this issue asap. Sorry for the delay.

@elbenfreund

This comment has been minimized.

Contributor

elbenfreund commented Aug 1, 2017

I can confirm the original issue and @maneesha s fix. Thanks everyone.
I opened a PR with the fix in case you are interested.

elbenfreund added a commit to elbenfreund/pelican-blueidea that referenced this issue Aug 1, 2017

[nasskach#5] Fix broken 'PAGES' template variable
Pages were not displayed in the menue because the template variable used
``PAGES``) should not be in all-caps but ``pages`` instead.
This commit fixes this.

Closes: nasskach#5

@nasskach nasskach closed this in #6 Aug 1, 2017

nasskach added a commit that referenced this issue Aug 1, 2017

Merge pull request #6 from elbenfreund/master
[#5] Fix broken 'PAGES' template variable
@nasskach

This comment has been minimized.

Owner

nasskach commented Aug 1, 2017

Thanks everyone.

deejoe pushed a commit to Lugor/lugor.github.io-src that referenced this issue Sep 17, 2017

Joe
Bugfix for error in template, replacing 'PAGES' with 'pages' to ensur…
…e pages are displayed in a header on the main page.

See, for example:

    nasskach/pelican-blueidea#5

This bug arises on moving from Pelican 3.6.3 to 3.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment