Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CameraPreview faster #403

Merged
merged 1 commit into from Mar 5, 2019

Conversation

@natario1
Copy link
Owner

commented Mar 5, 2019

Remove old logic that was just unneeded and caused recreating the gl surface when CameraView changes dimensions.

@codecov

This comment has been minimized.

Copy link

commented Mar 5, 2019

Codecov Report

Merging #403 into master will increase coverage by <.1%.
The diff coverage is 33.3%.

Impacted Files Coverage Δ Complexity Δ
.../com/otaliastudios/cameraview/GlCameraPreview.java 59.3% <33.3%> (+3.3%) 15 <1> (ø) ⬇️

@natario1 natario1 merged commit fc4a75a into master Mar 5, 2019

2 of 3 checks passed

codecov/patch 33.3% of diff hit (target 70%)
Details
codecov/project 41.5% (target 40%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@natario1 natario1 deleted the fix/onsurfacechanged branch Mar 5, 2019

cneuwirt added a commit to Miruken-Kotlin/CameraView that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.