Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setAutoFocusResetDelay to api to control autofocus reset options #435

Merged
merged 3 commits into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@cneuwirt
Copy link
Contributor

commented Apr 4, 2019

Certain devices with low-end cameras are slow to perform auto-focus. My changes add an additional parameter to startAutoFocus which will suppress the reset of auto-focus which will retain the current focus for future usages (scans, pictures, ...)

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

The build seemed to fail while running the emulator

@natario1

This comment has been minimized.

Copy link
Owner

commented Apr 4, 2019

Cool! The build is broken for other reasons which I am investigating.
Can you

  • add the cameraAutoFocusResetDelay XML attribute
  • document it in the More Features page (docs folder) alongside other XML attrs
@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

I pushed the change with cameraAutoFocusResetDelay xml attribute and associated documentation.

@natario1
Copy link
Owner

left a comment

I suggested some small changes and a typo to be fixed in documentation. Thank you!

@natario1 natario1 merged commit 3261b73 into natario1:master Apr 5, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@natario1

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2019

Thanks!

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Thank you. You really write some of the nicest and functional Android code I have seen.

@cneuwirt cneuwirt deleted the Miruken-Kotlin:setAutoFocusResetDelay branch Apr 5, 2019

@natario1

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2019

Thanks! And I am hireable for any kind of job! :-)

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

That's good to know. I actually work for a company called Improving. We have been trying to expand our mobile presence with full-time and contract personnel. We have offices all over the US as well as Canada. Where are you located? Although remote opportunities come up from time to tome.

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

When do you plan to release a new version which includes this change?

@natario1

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2019

Would you mind sending an email? Might be next week, I want to fix the build issue and merge #431 .

Maybe you can use jitpack master-SNAPSHOT to get this now. Not sure though, take a look at their website

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Sounds good. thanks

@natario1

This comment has been minimized.

Copy link
Owner

commented Apr 5, 2019

Could you also let me know if you try and succeed with jitpack? could add this SNAPSHOT thing into documentation

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

I will try but I'll be honest, I am pretty new to the Android world so I would have to research what is involved. Kotlin has made Android development much more approachable for me since I do all my development (in all environments) using a framework called Miruken. Java is too verbose and lacking syntax to express the core tenets of the framework, but Kotlin rocks.

@cneuwirt

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.