Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 514 #528

Merged
merged 19 commits into from Aug 1, 2019

Conversation

@natario1
Copy link
Owner

commented Jul 31, 2019

  • Fixes #514
  • Improves picture snapshot recorder
  • Improves thread management
@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #528 into master will increase coverage by 2.6%.
The diff coverage is 87.1%.

Impacted Files Coverage Δ Complexity Δ
...iastudios/cameraview/internal/egl/EglViewport.java 98.4% <100%> (+6.1%) 8 <1> (+3) ⬆️
...tudios/cameraview/internal/Issue514Workaround.java 100% <100%> (ø) 4 <4> (?)
...udios/cameraview/internal/utils/WorkerHandler.java 92.8% <71.4%> (-4.1%) 23 <3> (+2)
...taliastudios/cameraview/overlay/OverlayDrawer.java 87.5% <87.5%> (ø) 6 <6> (?)
...taliastudios/cameraview/gesture/GestureFinder.java 96% <0%> (+4%) 16% <0%> (+1%) ⬆️
...tudios/cameraview/internal/egl/EglBaseSurface.java 25.3% <0%> (+25.3%) 5% <0%> (+5%) ⬆️
...otaliastudios/cameraview/internal/egl/EglCore.java 40.3% <0%> (+40.3%) 9% <0%> (+9%) ⬆️
natario1 added 2 commits Jul 31, 2019

@natario1 natario1 merged commit 42de6e3 into master Aug 1, 2019

3 checks passed

codecov/patch 87.1% of diff hit (target 70%)
Details
codecov/project 70.5% (target 40%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@natario1 natario1 deleted the workaround-514 branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.