LPS-16504 #1

Merged
merged 1 commit into from Jun 20, 2011

Conversation

Projects
None yet
2 participants

Nate, please review LPS-16504 - Message Board portlet quick reply no longer focuses on the newly opened editor

natecavanaugh added a commit that referenced this pull request Jun 20, 2011

Merge pull request #1 from ipeychev/liferay-portal
---

Nate, please review LPS-16504 - Message Board portlet quick reply no longer focuses on the newly opened editor

@natecavanaugh natecavanaugh merged commit b870516 into natecavanaugh:master Jun 20, 2011

Why do we need the setTimeout here? Is this a case where we'll need a setTimeout every time we call editor.focus() ?

If so, we should put the setTimeout in the focus method itself. If it's just a one off case that's special because of something else, let me know what that is, and we can leave it here.

Owner

ipeychev replied Jun 21, 2011

In this situation we are clicking on a link and making editor's container visible. Without this timeout, CKEditor and FCKEditor just does not receive the focus - the link does instead.
It shouldn't be in the API method because it works in general. This timeout is needed in situations like those.

natecavanaugh pushed a commit that referenced this pull request Jan 14, 2015

LPS-51882 Separate test concern so we have 2 tests: #1 test to make s…
…ure that the data return by BlogsEntryAttachmentFileEntryReference is correct and is used properly #2 make sure that the content of the blog entry is correctly replaced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment