Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix interstore/unionstore #55

Merged
merged 2 commits into from Aug 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

david commented Feb 9, 2012

Hey Nate,

the redis.rb API for zinterstore/zunionstore seems to have changed at some point, so I changed #interstore/#unionstore to reflect that.

Also keep in mind that zinter/zunion were removed from redis, so the #intersection/#union methods only work with older redis/redis.rb versions. antirez's proposed fix is here: http://code.google.com/p/redis/issues/detail?id=328. I would have implemented it but I have no use for it right now, and no time, also.

Thanks for redis-objects. It came in handy. :)

David

Owner

nateware commented Feb 22, 2012

Thanks for this update. Any thoughts on the fact this would break older redis server versions? Not sure how to detect/handle that.

Contributor

david commented Mar 6, 2012

Nate, sorry about the late reply. Perhaps it would make sense to create a new version that clearly breaks backward compatibility? Does it make sense to track redis' versions numbers (so that redis-objects 2.6.x tracks redis 2.6)?

Owner

nateware commented Aug 10, 2012

I'll merge this into the redis-rb 3.0.0 chain so people can version lock based on that.

nateware added a commit that referenced this pull request Aug 10, 2012

Merge pull request #55 from david/master
Fix interstore/unionstore for redis 2.6

@nateware nateware merged commit 32370e4 into nateware:master Aug 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment