Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow for explicit user agents #20

Merged
merged 1 commit into from Nov 22, 2012

Conversation

Projects
None yet
2 participants
Collaborator

kpdecker commented Nov 20, 2012

No description provided.

Collaborator

metaskills commented Nov 20, 2012

So, I sort of anticipated this day might happen and I wonder if there is a more holistic way of being able to support all the PhantomJS arguments. Have any thoughts on that? Also, do you have any idea why the tests are failing now?

Collaborator

kpdecker commented Nov 20, 2012

I think this is a bit difficult as the things that I could envision myself wanting to use are strewn about in various location on the webpage config, some being on the settings object and others being on the config parameter root so I'm not certain that completely generic is possible here. I suspect that doing this explicitly in the mocha-phantomjs code is going to provide the best CLI for users.

Looking at the docs these are the parameters that seem like they could be useful for testing purposes but there could be others:

  • cookies
  • imagesEnabled
  • localToRemoteUrlAccessEnabled
  • username (I'd argue for mocks here but...)
  • password
  • viewportSize

Others?

unit tests: Just opened #21 on that. Looks like mocha changed the output slightly

@metaskills metaskills added a commit that referenced this pull request Nov 22, 2012

@metaskills metaskills Merge pull request #20 from kpdecker/user-agent-string
Allow for explicit user agents
0102c63

@metaskills metaskills merged commit 0102c63 into nathanboktae:master Nov 22, 2012

1 check failed

default The Travis build failed
Details
Collaborator

kpdecker commented Nov 22, 2012

I have a generic solution as well as a few fixes in the pipeline. Will try to get these in tonight.

Collaborator

metaskills commented Nov 22, 2012

Cool, thanks for the discussion. I tend to agree now that we can do these as needed. I will be pushing the 1.1.0 npm very soon.

So per my new rule of thumb, I am adding you as a collaborator now that you have done not only one, but two good pull requests 👍 If needed, I can push out npms. Thanks!

Collaborator

metaskills commented Nov 22, 2012

Take your time, I can release 1.1.0 after your done.

Collaborator

metaskills commented Nov 22, 2012

FYI, I have an email hook up, so I'll know when things are committed so I can keep up, comment, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment